[PATCH 3/3] drm/todo: Add TODO entry for "lints"
Maxime Ripard
mripard at kernel.org
Wed Jun 12 14:35:53 UTC 2024
Having lints would prove beneficial to prevent the same dark patterns
from reoccuring over and over again in drivers.
Add a TODO entry for that.
Signed-off-by: Maxime Ripard <mripard at kernel.org>
---
Documentation/gpu/todo.rst | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
index 94139c652663..16a9a24b33a6 100644
--- a/Documentation/gpu/todo.rst
+++ b/Documentation/gpu/todo.rst
@@ -717,10 +717,38 @@ doesn't or document it if it does would be of great help.
Contact: Maxime Ripard <mripard at kernel.org>
Level: Intermediate
+Create lints for KMS drivers
+----------------------------
+
+Over time, we've accumulated a list of dark patterns in KMS drivers that
+should be avoided. However, none of them are published anywhere, and not
+all reviewers are aware of them. It creates a situation where we have
+more drivers with problematic / deprecated code, even though we know
+that they shouldn't.
+
+We should create a set of coccinelle scripts that match these patterns,
+and make new drivers run that list. And possibly integrate them in CI.
+
+These patterns include:
+
+ - Drivers using kzalloc() or devm_kzalloc() to allocate their memory,
+ instead of drmm_kzalloc().
+
+ - Drivers not protecting their device resources (MMIO, clocks,
+ regulators, etc.) by drm_dev_enter() and drm_dev_exit().
+
+ - Drivers using drm_dev_unregister() instead of drm_dev_unplug().
+
+ - Drivers not calling drm_atomic_helper_shutdown() at shutdown
+
+Contact: Maxime Ripard <mripard at kernel.org>
+
+Level: Intermediate
+
Enable trinity for DRM
----------------------
And fix up the fallout. Should be really interesting ...
--
2.45.2
More information about the dri-devel
mailing list