[PATCH v5 0/3] SII902X HDMI Bridge fixups

Jayesh Choudhary j-choudhary at ti.com
Thu Jun 13 08:38:02 UTC 2024


- Move the mode_valid hook to drm_bridge_funcs structure to take care
  of the case when the encoder attaches the bridge chain with the
  DRM_BRIDGE_ATTACH_NO_CONNECTOR flag in which case, the connector is
  not initialized in the bridge's attach call and mode_valid is not
  called.

- Also add this check to the atomic_check call as suggested by Maxime in
  v1 patch.

- Move from deprecated enable()/disable() hooks to atomic hooks as
  suggested in v4 by Sam

Testing has been done on AM62X platform which have SII902X HDMI bridge.
>From the logs we can see the propagated modes and flip test for 1080p
resolution.

Testlog:
<https://gist.github.com/Jayesh2000/9bea6840672869337039296bc1145df4>

Changelog v4->v5:
- Add followup patch to replace deprecated bridge hooks
- Fix atomic check to return negative value
- Made commit message for [1/2] in v4 more clear while keeping the R-by and
  Acked-by tags.
- Fix commit header for [2/2] in v4

v4 patch:
<https://lore.kernel.org/all/20240530092930.434026-1-j-choudhary@ti.com/>

Changelog v3->v4:
- Remove mode_valid hook from connector_helper_funcs as it is not needed.

v3 patch:
<https://lore.kernel.org/all/20240524093509.127189-1-j-choudhary@ti.com/>

Changelog v2->v3:
- Remove newline that was introduced in [1/2] and later deleted in [2/2]
  in v2

v2 patch:
<https://lore.kernel.org/all/20240524073305.107293-1-j-choudhary@ti.com/>

Changelog v1->v2:
- Add KHZ suffix in the macros to be more clear
- Add the hook for drm_bridge_funcs as well
- Add check in atomic_check dunction call (in a separate patch)

v1 patch:
<https://lore.kernel.org/all/20240408081435.216927-1-j-choudhary@ti.com/>

Jayesh Choudhary (3):
  drm/bridge: sii902x: Fix mode_valid hook
  drm/bridge: sii902x: Support atomic bridge APIs
  drm/bridge: sii902x: Add pixel clock check in atomic_check

 drivers/gpu/drm/bridge/sii902x.c | 46 +++++++++++++++++++++++---------
 1 file changed, 33 insertions(+), 13 deletions(-)

-- 
2.25.1



More information about the dri-devel mailing list