[PATCH] drm/mediatek: Remove less-than-zero comparison of an unsigned value

CK Hu (胡俊光) ck.hu at mediatek.com
Mon Jun 17 01:19:39 UTC 2024


Hi, Shawn:

On Fri, 2024-06-14 at 11:49 +0800, Shawn Sung wrote:
> From: Hsiao Chien Sung <shawn.sung at mediatek.com>
> 
> Fix a Coverity error that less-than-zero comparison of an unsigned value
> is never true.

Reviewed-by: CK Hu <ck.hu at mediatek.com>

> 
> Fixes: 0d9eee9118b7 ("drm/mediatek: Add drm ovl_adaptor sub driver for MT8195")
> Signed-off-by: Hsiao Chien Sung <shawn.sung at mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_ddp_comp.c
> index 17b036411292..a66e46d0b45e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_ddp_comp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_ddp_comp.c
> @@ -593,7 +593,7 @@ int mtk_ddp_comp_init(struct device_node *node, struct mtk_ddp_comp *comp,
>  	int ret;
>  #endif
>  
> -	if (comp_id < 0 || comp_id >= DDP_COMPONENT_DRM_ID_MAX)
> +	if (comp_id >= DDP_COMPONENT_DRM_ID_MAX)
>  		return -EINVAL;
>  
>  	type = mtk_ddp_matches[comp_id].type;
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20240617/bbf1f6b6/attachment-0001.htm>


More information about the dri-devel mailing list