[PATCH 3/4] drm: rcar-mipi-dsi: Add support for R8A779H0

Krzysztof Kozlowski krzk at kernel.org
Wed Jun 19 11:07:24 UTC 2024


On 19/06/2024 12:22, Jacopo Mondi wrote:
> Add support for R-Car R8A779H0 V4M which has the same characteristics
> of the already supported R-Car V4H R8A779G0.
> 
> Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> 

Please run scripts/checkpatch.pl and fix reported warnings. Then please
run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
Some warnings can be ignored, especially from --strict run, but the code
here looks like it needs a fix. Feel free to get in touch if the warning
is not clear.

Bindings are separate patches.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline), work on fork of kernel
(don't, instead use mainline) or you ignore some maintainers (really
don't). Just use b4 and everything should be fine, although remember
about `b4 prep --auto-to-cc` if you added new patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time, thus I will skip this patch entirely till you follow
the process allowing the patch to be tested.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

Best regards,
Krzysztof



More information about the dri-devel mailing list