[PATCH] dma-buf/heaps: Correct the types of fd_flags and heap_flags

Sumit Semwal sumit.semwal at linaro.org
Wed Jun 19 14:37:38 UTC 2024


Hi Barry,

On Mon, 10 Jun 2024 at 22:14, Carlos Llamas <cmllamas at google.com> wrote:
>
> On Thu, Jun 06, 2024 at 02:02:13PM +1200, Barry Song wrote:
> > From: Barry Song <v-songbaohua at oppo.com>
> >
> > dma_heap_allocation_data defines the UAPI as follows:
> >
> >  struct dma_heap_allocation_data {
> >         __u64 len;
> >         __u32 fd;
> >         __u32 fd_flags;
> >         __u64 heap_flags;
> >  };
> >
> > But dma heaps are casting both fd_flags and heap_flags into
> > unsigned long. This patch makes dma heaps - cma heap and
> > system heap have consistent types with UAPI.
> >
> > Signed-off-by: Barry Song <v-songbaohua at oppo.com>

Thanks for this cleanup; pushed to drm-misc-next.

> > ---
>
> Looks good to me, thanks!
>
> Reviewed-by: Carlos Llamas <cmllamas at google.com>


Best,
Sumit.


More information about the dri-devel mailing list