[PATCH v4 4/4] drm/panel: jd9365da: Add the function of adjusting orientation
Doug Anderson
dianders at google.com
Fri Jun 21 19:33:49 UTC 2024
Hi,
On Thu, Jun 20, 2024 at 1:05 AM Zhaoxiong Lv
<lvzhaoxiong at huaqin.corp-partner.google.com> wrote:
>
> @@ -893,6 +901,12 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
> drm_panel_init(&jadard->panel, dev, &jadard_funcs,
> DRM_MODE_CONNECTOR_DSI);
>
> + ret = of_drm_get_panel_orientation(dev->of_node, &jadard->orientation);
> + if (ret < 0) {
> + dev_err(dev, "%pOF: failed to get orientation %d\n", dev->of_node, ret);
> + return ret;
> + }
nit: use dev_err_probe(). Also no need to include a %pOF, AKA:
if (ret < 0)
return dev_err_probe(dev, ret, "Failed to get orientation\n");
More information about the dri-devel
mailing list