[PATCH] drm/amdgpu: fix a possible null pointer dereference

[Markus Elfring]

> In amdgpu_connector_add_common_modes(), the return value of drm_cvt_mode()
> is assigned to mode, which will lead to a NULL pointer dereference on
> failure of drm_cvt_mode(). Add a check to avoid npd.

Can a wording approach (like the following) be a better change description?

   A null pointer is stored in the local variable “mode” after a call
   of the function “drm_cvt_mode” failed. This pointer was passed to
   a subsequent call of the function “drm_mode_probed_add” where an undesirable
   dereference will be performed then.
   Thus add a corresponding return value check.


Would you like to add any tags (like “Fixes”) accordingly?


How do you think about to use a summary phrase like “Avoid null pointer dereference
in amdgpu_connector_add_common_modes()”?

Regards,
Markus