[PATCH v5 4/5] drm/panel: jd9365da: Support for kd101ne3-40ti MIPI-DSI panel
Doug Anderson
dianders at google.com
Mon Jun 24 16:45:39 UTC 2024
Hi,
On Mon, Jun 24, 2024 at 7:21 AM Zhaoxiong Lv
<lvzhaoxiong at huaqin.corp-partner.google.com> wrote:
>
> The K&d kd101ne3-40ti is a 10.1" WXGA TFT-LCD panel, use
> jd9365da controller,which fits in nicely with the existing
> panel-jadard-jd9365da-h3 driver.Hence,we add a new compatible
> with panel specific config.
>
> Although they have the same control IC, the two panels are different,
> and the timing will be slightly different, so we added some variables
> in struct jadard_panel_desc to control the timing.
>
> Signed-off-by: Zhaoxiong Lv <lvzhaoxiong at huaqin.corp-partner.google.com>
> ---
> Changes between V5 and V4:
> - 1. Add a "_ms" suffix to the variables.
> - 2. Use more "_multi" in the enable/disable function
> - 3. Use mipi_dsi_dcs_write_seq_multi() in the init() function.
>
> V4:https://lore.kernel.org/all/20240620080509.18504-4-lvzhaoxiong@huaqin.corp-partner.google.com/
>
> Changes between V4 and V3:
> - 1. Use mipi_dsi_msleep.
> - 2. Adjust the ".clock" assignment format.
> - 3. Adjust "compatible" positions to keep the list sorted.
>
> V3:https://lore.kernel.org/all/20240614145510.22965-4-lvzhaoxiong@huaqin.corp-partner.google.com/
>
> Changes between V3 and V2:
> - 1. Give up creating a new driver and re-add K&d kd101ne3-40ti
> - configuration to the panel-jadard-jd9365da-h3.c driver.
>
> V2:https://lore.kernel.org/all/20240601084528.22502-3-lvzhaoxiong@huaqin.corp-partner.google.com/
>
> Changes between V2 and V1:
> - 1. Use the new mipi_dsi_dcs_write_seq_multi() function.
> - 2. Modify Move mipi_dsi_dcs_set_display_off() and mipi_dsi_dcs_enter_sleep_mode() to disable(),
> - and drop kingdisplay_panel_enter_sleep_mode().
> - 3. If prepare fails, disable GPIO before regulators.
> - 4. This function drm_connector_set_panel_orientation() is no longer used. Delete it.
> - 5. Drop ".shutdown = kingdisplay_panel_shutdown".
>
> ---
> .../gpu/drm/panel/panel-jadard-jd9365da-h3.c | 277 ++++++++++++++++++
> 1 file changed, 277 insertions(+)
It still seems weird to me that the other variants of the same panel
don't need similar delays, but the code looks fine to me now:
Reviewed-by: Douglas Anderson <dianders at chromium.org>
More information about the dri-devel
mailing list