[PATCH 3/3] dt-bindings: display: panel: correct Anbernic RG35XX panel example

Ryan Walklin ryan at testtoast.com
Sun Jun 30 08:25:26 UTC 2024


Hi Conor,

On Thu, 27 Jun 2024, at 3:38 AM, Conor Dooley wrote:
> On Wed, Jun 26, 2024 at 11:17:50PM +1200, Ryan Walklin wrote:
>> make dt_bindings_check reports that sck-gpios and num-chipselects are
>> required for spi nodes, therefore add these to the example.


> huh, are you sure it does? It doesn't for me...

With:
make dt_binding_check -j32 -s -W 2

I get the following output:

/home/ryan/Projects/Develop/RG35XX+/kernel/linux/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.example.dtb: spi: 'num-chipselects' is a required property
	from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#
/home/ryan/Projects/Develop/RG35XX+/kernel/linux/Documentation/devicetree/bindings/display/panel/anbernic,wl-355608-a8.example.dtb: spi: 'sck-gpios' is a required property
	from schema $id: http://devicetree.org/schemas/spi/spi-gpio.yaml#

The relevant section from spi-gpio.yaml seems to be:

required:
  - compatible
  - num-chipselects
  - sck-gpios

I am happy to leave this out if a simpler example is desired, but alternately if the chipselects/sck-gpios should stay then I would suggest a better example would include the mosi/miso/cs GPIOs as well which would make the example functional.

Regards,

Ryan


More information about the dri-devel mailing list