[PATCH v3 00/10] Make PCI's devres API more consistent
Philipp Stanner
pstanner at redhat.com
Fri Mar 1 09:29:42 UTC 2024
On Thu, 2024-02-29 at 14:57 -0600, Bjorn Helgaas wrote:
> On Thu, Feb 29, 2024 at 09:31:20AM +0100, Philipp Stanner wrote:
> > @Bjorn:
> > Hey Bjorn, are we good with this series? Any more wishes or
> > suggestions?
>
> Sorry, haven't had a chance to go through it yet.
>
> FWIW, I just tried to apply these on top of pci/devres, but it failed
> here:
>
> Applying: PCI: Add new set of devres functions
> Applying: PCI: Deprecate iomap-table functions
> Applying: PCI: Warn users about complicated devres nature
> Applying: PCI: Make devres region requests consistent
> Applying: PCI: Move dev-enabled status bit to struct pci_dev
> error: patch failed: drivers/pci/pci.h:811
> error: drivers/pci/pci.h: patch does not apply
> Patch failed at 0005 PCI: Move dev-enabled status bit to struct
> pci_dev
>
> Haven't investigated, so maybe it's some trivial easily fixed thing.
For me, based on Linus's master, this applies with the previous series.
It seems to me that this issue only exists on linux-next, the reason
being that git searches for struct pci_devres in line 811, but on
linux-next, because of previous additions, the struct moved to line
827, and poor git can't find it anymore.
I could fix that and provide a v4.
P.
>
> Bjorn
>
More information about the dri-devel
mailing list