[PATCH 3/3] drm/panthor: Fix undefined panthor_device_suspend/resume symbol issue
Jani Nikula
jani.nikula at linux.intel.com
Mon Mar 11 11:49:56 UTC 2024
On Mon, 11 Mar 2024, Boris Brezillon <boris.brezillon at collabora.com> wrote:
> On Mon, 11 Mar 2024 13:05:01 +0200
> Jani Nikula <jani.nikula at linux.intel.com> wrote:
>
>> This breaks the config for me:
>>
>> SYNC include/config/auto.conf.cmd
>> GEN Makefile
>> drivers/iommu/Kconfig:14:error: recursive dependency detected!
>> drivers/iommu/Kconfig:14: symbol IOMMU_SUPPORT is selected by DRM_PANTHOR
>> drivers/gpu/drm/panthor/Kconfig:3: symbol DRM_PANTHOR depends on PM
>> kernel/power/Kconfig:183: symbol PM is selected by PM_SLEEP
>> kernel/power/Kconfig:117: symbol PM_SLEEP depends on HIBERNATE_CALLBACKS
>> kernel/power/Kconfig:35: symbol HIBERNATE_CALLBACKS is selected by XEN_SAVE_RESTORE
>> arch/x86/xen/Kconfig:67: symbol XEN_SAVE_RESTORE depends on XEN
>> arch/x86/xen/Kconfig:6: symbol XEN depends on PARAVIRT
>> arch/x86/Kconfig:781: symbol PARAVIRT is selected by HYPERV
>> drivers/hv/Kconfig:5: symbol HYPERV depends on X86_LOCAL_APIC
>> arch/x86/Kconfig:1106: symbol X86_LOCAL_APIC depends on X86_UP_APIC
>> arch/x86/Kconfig:1081: symbol X86_UP_APIC prompt is visible depending on PCI_MSI
>> drivers/pci/Kconfig:39: symbol PCI_MSI is selected by AMD_IOMMU
>> drivers/iommu/amd/Kconfig:3: symbol AMD_IOMMU depends on IOMMU_SUPPORT
>
> Uh, I guess we want a "depends on IOMMU_SUPPORT" instead of "select
> IOMMU_SUPPORT" in panthor then.
That works for me.
>
>> For a resolution refer to Documentation/kbuild/kconfig-language.rst
>> subsection "Kconfig recursive dependency limitations"
--
Jani Nikula, Intel
More information about the dri-devel
mailing list