[PATCH] Revert "drm/panthor: Fix undefined panthor_device_suspend/resume symbol issue"

Jani Nikula jani.nikula at intel.com
Mon Mar 11 15:52:59 UTC 2024


On Mon, 11 Mar 2024, Liviu Dudau <liviu.dudau at arm.com> wrote:
> On Mon, Mar 11, 2024 at 04:49:30PM +0200, Jani Nikula wrote:
>> On Mon, 11 Mar 2024, Liviu Dudau <liviu.dudau at arm.com> wrote:
>> > So with this revert we're OK with an undefined symbol if !CONFIG_PM, but we're not happy
>> > with a recursive dependency that is only triggered for COMPILE_TEST? I would've thought
>> > IOMMU_SUPPORT options is a better one.
>> 
>> It's a real config.
>> 
>> # CONFIG_COMPILE_TEST is not set
>
> So I can select CONFIG_ARM64 and CONFIG_X86_LOCAL_APIC at the same time? DRM_PANTHOR depends on ARM || ARM64
> and X86_LOCAL_APIC depends on X86_64. At some moment the recursive dependency detector should've stopped as
> there are no common dependencies between DRM_PANTHOR and X86_LOCAL_APIC and going further just triggers false
> positives. I'm curious how you've created your config now.

The thing is, I don't have *any* of the dependencies ARM || ARM64 ||
COMPILE_TEST set in the config that triggered this. I don't have
DRM_PANTHOR set. But make olddefconfig detects a circular dependency
nonetheless.

It's possible the issue is in kconfig. I don't know. But not being able
to even dodge the warning makes it a show stopper. I wouldn't even know
what to change in the config.


BR,
Jani.


-- 
Jani Nikula, Intel


More information about the dri-devel mailing list