[PATCH 1/6] auxdisplay/ht16k33: Replace use of fb_blank with backlight helper

[Robin van der Gracht]

Hi Thomas,

Thank you for submitting your patch, it looks fine to me.

Reviewed-by: Robin van der Gracht <robin at protonic.nl>

On Wed, 13 Mar 2024 16:45:00 +0100
Thomas Zimmermann <tzimmermann at suse.de> wrote:

> Replace the use of struct backlight_properties.fb_blank with a
> call to backlight_get_brightness(). The helper implement the same
> logic as the driver's function.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Robin van der Gracht <robin at protonic.nl>
> Cc: Miguel Ojeda <ojeda at kernel.org>
> ---
>  drivers/auxdisplay/ht16k33.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/auxdisplay/ht16k33.c
> b/drivers/auxdisplay/ht16k33.c index a90430b7d07ba..83db829b97a5e
> 100644 --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -314,14 +314,9 @@ static int ht16k33_initialize(struct
> ht16k33_priv *priv) 
>  static int ht16k33_bl_update_status(struct backlight_device *bl)
>  {
> -	int brightness = bl->props.brightness;
> +	int brightness = backlight_get_brightness(bl);
>  	struct ht16k33_priv *priv = bl_get_data(bl);
>  
> -	if (bl->props.power != FB_BLANK_UNBLANK ||
> -	    bl->props.fb_blank != FB_BLANK_UNBLANK ||
> -	    bl->props.state & BL_CORE_FBBLANK)
> -		brightness = 0;
> -
>  	return ht16k33_brightness_set(priv, brightness);
>  }
>