EXTERNAL: Re: [PATCH v2 6/6] backlight: Remove fb_blank from struct backlight_properties

FLAVIO SULIGOI f.suligoi at asem.it
Wed Mar 20 09:00:13 UTC 2024


HI Thomas,

...
> >> Remove the field fb_blank from struct backlight_properties and remove
> >> all code that still sets or reads it. Backlight blank status is now
> >> tracked exclusively in struct backlight_properties.state.
> >>
> >> The core backlight code keeps the fb_blank and state fields in sync,
> >> but doesn't do anything else with fb_blank. Several drivers
> >> initialize fb_blank to FB_BLANK_UNBLANK to enable the backlight. This
> >> is already the default for the state field. So we can delete the
> >> fb_blank code from core and drivers and rely on the state field.
> >>
> >> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> >> Cc: Flavio Suligoi <f.suligoi at asem.it>
> >> Cc: Nicolas Ferre <nicolas.ferre at microchip.com>
> >> Cc: Alexandre Belloni <alexandre.belloni at bootlin.com>
> >> Cc: Claudiu Beznea <claudiu.beznea at tuxon.dev>
> >> Tested-by: Flavio Suligoi <f.suligoi at asem.it>
> >> Reviewed-by: Daniel Thompson <daniel.thompson at linaro.org>
> >> Reviewed-by: Dan Carpenter <dan.carpenter at linaro.org>
> > ...
> >
> > Can you explain what are the differences between the version 1 and version
> 2 of the patch?
> 
> There are none. It's simply labeled v2 because it is part of the version
> 2 of this series.
...

Ah, ok. Sorry for my question, but having received only this email from the series,
I didn't understand why version two.
It's all clear now!

Best regards,
Flavio


More information about the dri-devel mailing list