[v5,06/13] drm/ast: Rename struct ast_i2c_chan to struct ast_ddc

Sui Jingfeng sui.jingfeng at linux.dev
Wed Mar 20 17:32:46 UTC 2024


Hi,


On 2024/3/20 17:34, Thomas Zimmermann wrote:
> The struct struct ast_i2c_chan represents the Display Data Channel
> (DDC); I2C is the underlying bus. Rename the structure, the variables
> and the helper ast_i2c_create() to ddc-like terms. No functional
> changes.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>


Personally, I think _i2c_ is better name than _ddc_. Because It seems that
the Display Data Channel is comes from VESA standard, while aspeed I2C can
be used to configure the external display bridges(encoder). So _i2c_ is a
*abstract* name, and can be utilized to do something else beyond the DDC
itself.


Reviewed-by: Sui Jingfeng <sui.jingfeng at linux.dev>

-- 
Best regards,
Sui



More information about the dri-devel mailing list