[PATCH] drm: bridge: thc63lvd1024: Print error message when DT parsing fails

Sui Jingfeng sui.jingfeng at linux.dev
Wed Mar 20 20:04:56 UTC 2024


On 2024/3/19 23:49, Neil Armstrong wrote:
> On 18/03/2024 20:23, Sui Jingfeng wrote:
>> Hi,
>>
>>
>> On 2024/3/19 02:04, Laurent Pinchart wrote:
>>> Improving core helpers is certainly a good idea, and if we do so, we 
>>> can
>>> simplify drivers. What I'm concerned is that commit 00084f0c01bf 
>>> creates
>>> a silent probe failure path,
>>
>>
>> No, I can't agree here. It doesn't creates a silent probe failure path.
>
> It doesn't _in debug mode_, I agree with Laurent, having a verbose 
> probe error should be kept.
>
OK, I agree with you two then.

I means that we could replace the pr_debug() with the pr_err() in the
of_graph_get_remote_node() function, then all drivers will be benefit.
Is this idea too hard to be acceptable?


> Neil 



More information about the dri-devel mailing list