[PATCH 6/6] drm/msm/dp: Use function arguments for audio operations

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Tue Mar 26 17:50:49 UTC 2024


On Tue, 26 Mar 2024 at 17:06, Bjorn Andersson <andersson at kernel.org> wrote:
>
> From: Bjorn Andersson <quic_bjorande at quicinc.com>
>
> The dp_audio read and write operations uses members in struct dp_catalog
> for passing arguments and return values. This adds unnecessary
> complexity to the implementation, as it turns out after detangling the
> logic that no state is actually held in these variables.
>
> Clean this up by using function arguments and return values for passing
> the data.
>
> Signed-off-by: Bjorn Andersson <quic_bjorande at quicinc.com>
> ---
>  drivers/gpu/drm/msm/dp/dp_audio.c   | 20 +++++--------------
>  drivers/gpu/drm/msm/dp/dp_catalog.c | 39 +++++++++++++------------------------
>  drivers/gpu/drm/msm/dp/dp_catalog.h | 18 +++++++++--------
>  3 files changed, 28 insertions(+), 49 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>

Thanks a lot for the cleanup!

--
With best wishes
Dmitry


More information about the dri-devel mailing list