[PATCH v4 10/16] drm/msm: generate headers on the fly

Abhinav Kumar quic_abhinavk at quicinc.com
Tue Mar 26 23:48:56 UTC 2024



On 3/22/2024 3:57 PM, Dmitry Baryshkov wrote:
> Generate DRM/MSM headers on the fly during kernel build. This removes a
> need to push register changes to Mesa with the following manual
> synchronization step. Existing headers will be removed in the following
> commits (split away to ease reviews).
> 

This change does two things:

1) move adreno folder compilation under "adreno-y", move display related 
files compilation undere "msm-display-y", move common files under "msm-y"

2) changes to generate the header using gen_header.py

Why not split it into two changes?

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> ---
>   drivers/gpu/drm/msm/.gitignore |  1 +
>   drivers/gpu/drm/msm/Makefile   | 97 +++++++++++++++++++++++++++++++++---------
>   drivers/gpu/drm/msm/msm_drv.c  |  3 +-
>   drivers/gpu/drm/msm/msm_gpu.c  |  2 +-
>   4 files changed, 80 insertions(+), 23 deletions(-)
> 

<snip>

Are below two changes related to this patch?

> +targets += $(ADRENO_HEADERS) $(DISPLAY_HEADERS)
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 97790faffd23..9c33f4e3f822 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -17,8 +17,9 @@
>   
>   #include "msm_drv.h"
>   #include "msm_debugfs.h"
> +#include "msm_gem.h"
> +#include "msm_gpu.h"
>   #include "msm_kms.h"
> -#include "adreno/adreno_gpu.h"
>   
>   /*
>    * MSM driver version:
> diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
> index 655002b21b0d..cd185b9636d2 100644
> --- a/drivers/gpu/drm/msm/msm_gpu.c
> +++ b/drivers/gpu/drm/msm/msm_gpu.c
> @@ -11,7 +11,7 @@
>   #include "msm_mmu.h"
>   #include "msm_fence.h"
>   #include "msm_gpu_trace.h"
> -#include "adreno/adreno_gpu.h"
> +//#include "adreno/adreno_gpu.h" 

you can just drop this line

>   
>   #include <generated/utsrelease.h>
>   #include <linux/string_helpers.h>
> 


More information about the dri-devel mailing list