[PATCH 1/1] drm: arm: display: komeda: komeda_crtc: use 'time_left' variable with wait_for_completion_timeout()

Wolfram Sang wsa+renesas at sang-engineering.com
Sun May 5 13:25:11 UTC 2024


> >  	/* wait the flip take affect.*/
> > -	timeout = wait_for_completion_timeout(flip_done, HZ);
> > -	if (timeout == 0) {
> > +	time_left = wait_for_completion_timeout(flip_done, HZ);
> > +	if (time_left == 0) {
> 
> Honestly, if the name of the variable is confusing I would get rid of it completely. Can you
> send a patch that removes the timeout variable and here just does:
> 
> 	if (wait_for_completion_timeout(flip_done, HZ) == 0) {

Can do. I think, though, that using 'time_left' is still easier to
understand. However, this code block is simple enough and it is your
driver, so I'll send v2 later.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20240505/1cfe4eb0/attachment.sig>


More information about the dri-devel mailing list