[RFT PATCH v2 09/48] drm/panel: innolux-p079zca: Don't call unprepare+disable at shutdown/remove

Heiko Stübner heiko at sntech.de
Mon May 6 16:29:22 UTC 2024


Am Freitag, 3. Mai 2024, 23:32:50 CEST schrieb Douglas Anderson:
> It's the responsibility of a correctly written DRM modeset driver to
> call drm_atomic_helper_shutdown() at shutdown time and that should be
> disabling / unpreparing the panel if needed. Panel drivers shouldn't
> be calling these functions themselves.
> 
> A recent effort was made to fix as many DRM modeset drivers as
> possible [1] [2] [3] and most drivers are fixed now.
> 
> A grep through mainline for compatible strings used by this driver
> indicates that it is used by Rockchip boards. The Rockchip driver
> appears to be correctly calling drm_atomic_helper_shutdown() so we can
> remove the calls.
> 
> [1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
> [2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
> [3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org
> 
> Cc: Chris Zhong <zyw at rock-chips.com>
> Cc: Lin Huang <hl at rock-chips.com>
> Cc: Brian Norris <briannorris at chromium.org>
> Cc: "Heiko Stübner" <heiko at sntech.de>
> Signed-off-by: Douglas Anderson <dianders at chromium.org>

the underlying setup (rockchip-drm with dw-dsi) as well as the
change itself is similar to the ltk050h3146w variant, so I don't
see how this should behave differently ;-)

Reviewed-by: Heiko Stuebner <heiko at sntech.de>




More information about the dri-devel mailing list