[PATCH 1/2] dt-bindings: display: panel: Add WL-355608-A8 panel
Conor Dooley
conor at kernel.org
Fri May 24 19:10:15 UTC 2024
On Fri, May 24, 2024 at 10:33:13PM +1200, Ryan Walklin wrote:
> The WL-355608-A8 is a 3.5" 640x480 at 60Hz RGB LCD display from an unknown
> OEM, used in a number of handheld gaming devices made by Anbernic.
>
> Add a device tree binding for the panel.
>
> Signed-off-by: Ryan Walklin <ryan at testtoast.com>
> ---
> .../bindings/display/panel/wl-355608-a8.yaml | 68 +++++++++++++++++++
> 1 file changed, 68 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml b/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> new file mode 100644
> index 000000000..af12303e2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel
> +
> +maintainers:
> + - Ryan Walklin <ryan at testtoast.com>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +properties:
> + compatible:
> + const: wl-355608-a8
You're missing a vendor prefix here. And when you add it, update the
filename to match.
> +
> + reg:
> + maxItems: 1
> +
> + spi-3wire: true
> +
> +required:
> + - compatible
> + - reg
> + - port
> + - power-supply
> + - reset-gpios
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + spi_lcd: spi {
> + compatible = "spi-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sck-gpios = <&pio 8 9 GPIO_ACTIVE_HIGH>; // PI9
> + mosi-gpios = <&pio 8 10 GPIO_ACTIVE_HIGH>; // PI10
> + cs-gpios = <&pio 8 8 GPIO_ACTIVE_HIGH>; // PI8
> + num-chipselects = <1>;
All of this is not needed in the example, all you need to have here is:
spi {
#address-cells = <1>;
#size-cells = <0>;
> +
> + panel: panel at 0 {
This "panel" label is not used, you should drop it.
> + compatible = "wl_355608_a8";
This doesn't match what you documented, be sure to run dt_binding_check.
> + reg = <0>;
> +
> + spi-3wire;
> + spi-max-frequency = <3125000>;
> +
> + reset-gpios = <&pio 8 14 GPIO_ACTIVE_LOW>; // PI14
> +
> + backlight = <&backlight>;
> + power-supply = <®_lcd>;
> + pinctrl-0 = <&lcd0_rgb888_pins>;
> + pinctrl-names = "default";
> +
> + port {
> + panel_in_rgb: endpoint {
Neither is this label afaict.
Thanks,
Conor.
> + remote-endpoint = <&tcon_lcd0_out_lcd>;
> + };
> + };
> + };
> + };
> --
> 2.45.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20240524/6e9570c8/attachment.sig>
More information about the dri-devel
mailing list