[PATCH v3 3/3] drm: adv7511: Drop dsi single lane support

[Biju Das]

Hi Laurent,

Thanks for the feedback.

> -----Original Message-----
> From: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Sent: 06 November 2024 19:25
> Subject: Re: [PATCH v3 3/3] drm: adv7511: Drop dsi single lane support
> 
> Hi Biju,
> 
> Thank you for the patch.
> 
> On Wed, Nov 06, 2024 at 06:49:30PM +0000, Biju Das wrote:
> > As per [1], ADV7535/7533 support only 2-, 3-, or 4-lane. Drop
> > unsupported 1-lane.
> >
> > [1]
> > https://www.analog.com/media/en/technical-documentation/data-sheets/AD
> > V7535.pdf
> 
> No need for a line break, this should be
> 
> [1] https://www.analog.com/media/en/technical-documentation/data-sheets/ADV7535.pdf

OK. Will add the link to ADV7533 as well.

> 
> >
> > Fixes: 1e4d58cd7f88 ("drm/bridge: adv7533: Create a MIPI DSI device")
> > Reported-by: Hien Huynh <hien.huynh.px at renesas.com>
> 
> Reported-by is supposed to be immediately followed by a Closes: tag.
> 
> With those fixed,

There is no report available on the weblink. It is just private chat we discussed about the
out-of-bounds array issue. Check patch complained about missing Closes tag.

But as per [1], Closes tag report is not required for private bugs??

[1] https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

I will send next version if it is OK for you without the Closes tag

Or

Will just remove Reported-by tag to make check patch happy.

Please let me know.

Cheers,
Biju

> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> 
> > Cc: stable at vger.kernel.org
> > Signed-off-by: Biju Das <biju.das.jz at bp.renesas.com>
> > ---
> > Changes in v3:
> >  - Updated commit header and description
> >  - Updated fixes tag
> >  - Dropped single lane support
> > Changes in v2:
> >  - Added the tag "Cc: stable at vger.kernel.org" in the sign-off area.
> >  - Dropped Archit Taneja invalid Mail address
> > ---
> >  drivers/gpu/drm/bridge/adv7511/adv7533.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7533.c
> > b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> > index de55d687245a..ec360f8b7509 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7533.c
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7533.c
> > @@ -173,7 +173,7 @@ int adv7533_parse_dt(struct device_node *np,
> > struct adv7511 *adv)
> >
> >  	of_property_read_u32(np, "adi,dsi-lanes", &num_lanes);
> >
> > -	if (num_lanes < 1 || num_lanes > 4)
> > +	if (num_lanes < 2 || num_lanes > 4)
> >  		return -EINVAL;
> >
> >  	adv->num_dsi_lanes = num_lanes;
> 
> --
> Regards,
> 
> Laurent Pinchart