[PATCH 11/14] drm/msm/dp: move/inline audio related functions

[kernel test robot]

Hi Dmitry,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 74741a050b79d31d8d2eeee12c77736596d0a6b2]

url:    https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/drm-msm-dp-fix-msm_dp_utils_pack_sdp_header-interface/20241108-082302
base:   74741a050b79d31d8d2eeee12c77736596d0a6b2
patch link:    https://lore.kernel.org/r/20241108-fd-dp-audio-fixup-v1-11-40c8eeb60cf5%40linaro.org
patch subject: [PATCH 11/14] drm/msm/dp: move/inline audio related functions
config: x86_64-buildonly-randconfig-002-20241108 (https://download.01.org/0day-ci/archive/20241108/202411081748.0PPL9MIj-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241108/202411081748.0PPL9MIj-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411081748.0PPL9MIj-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/msm/dp/dp_audio.c:11:
   In file included from include/drm/display/drm_dp_helper.h:27:
   In file included from include/linux/i2c.h:19:
   In file included from include/linux/regulator/consumer.h:35:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:21:
   In file included from include/linux/mm.h:2223:
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> drivers/gpu/drm/msm/dp/dp_audio.c:213:5: warning: variable 'safe_to_exit_level' is uninitialized when used here [-Wuninitialized]
     213 |                                 safe_to_exit_level);
         |                                 ^~~~~~~~~~~~~~~~~~
   include/drm/drm_print.h:636:59: note: expanded from macro 'drm_dbg_dp'
     636 |         drm_dev_dbg((drm) ? (drm)->dev : NULL, DRM_UT_DP, fmt, ##__VA_ARGS__)
         |                                                                  ^~~~~~~~~~~
   include/drm/drm_print.h:540:39: note: expanded from macro 'drm_dev_dbg'
     540 |         __drm_dev_dbg(NULL, dev, cat, fmt, ##__VA_ARGS__)
         |                                              ^~~~~~~~~~~
   drivers/gpu/drm/msm/dp/dp_audio.c:198:24: note: initialize the variable 'safe_to_exit_level' to silence this warning
     198 |         u32 safe_to_exit_level, mainlink_levels;
         |                               ^
         |                                = 0
   2 warnings generated.


vim +/safe_to_exit_level +213 drivers/gpu/drm/msm/dp/dp_audio.c

d13e36d7d2227e Abhinav Kumar    2020-09-12  195  
fb7d509b1710d1 Dmitry Baryshkov 2024-10-29  196  static void msm_dp_audio_safe_to_exit_level(struct msm_dp_audio_private *audio)
d13e36d7d2227e Abhinav Kumar    2020-09-12  197  {
568837beeb38ef Dmitry Baryshkov 2024-11-08  198  	u32 safe_to_exit_level, mainlink_levels;
d13e36d7d2227e Abhinav Kumar    2020-09-12  199  
fb7d509b1710d1 Dmitry Baryshkov 2024-10-29  200  	switch (audio->msm_dp_audio.lane_count) {
d13e36d7d2227e Abhinav Kumar    2020-09-12  201  	case 1:
d13e36d7d2227e Abhinav Kumar    2020-09-12  202  		safe_to_exit_level = 14;
d13e36d7d2227e Abhinav Kumar    2020-09-12  203  		break;
d13e36d7d2227e Abhinav Kumar    2020-09-12  204  	case 2:
d13e36d7d2227e Abhinav Kumar    2020-09-12  205  		safe_to_exit_level = 8;
d13e36d7d2227e Abhinav Kumar    2020-09-12  206  		break;
d13e36d7d2227e Abhinav Kumar    2020-09-12  207  	case 4:
d13e36d7d2227e Abhinav Kumar    2020-09-12  208  		safe_to_exit_level = 5;
d13e36d7d2227e Abhinav Kumar    2020-09-12  209  		break;
d13e36d7d2227e Abhinav Kumar    2020-09-12  210  	default:
202aceac8bb3ae Kuogee Hsieh     2022-02-17  211  		drm_dbg_dp(audio->drm_dev,
202aceac8bb3ae Kuogee Hsieh     2022-02-17  212  				"setting the default safe_to_exit_level = %u\n",
d13e36d7d2227e Abhinav Kumar    2020-09-12 @213  				safe_to_exit_level);
d13e36d7d2227e Abhinav Kumar    2020-09-12  214  		safe_to_exit_level = 14;
d13e36d7d2227e Abhinav Kumar    2020-09-12  215  		break;
d13e36d7d2227e Abhinav Kumar    2020-09-12  216  	}
d13e36d7d2227e Abhinav Kumar    2020-09-12  217  
568837beeb38ef Dmitry Baryshkov 2024-11-08  218  	mainlink_levels = msm_dp_read_link(audio->catalog, REG_DP_MAINLINK_LEVELS);
568837beeb38ef Dmitry Baryshkov 2024-11-08  219  	mainlink_levels &= 0xFE0;
568837beeb38ef Dmitry Baryshkov 2024-11-08  220  	mainlink_levels |= safe_to_exit_level;
568837beeb38ef Dmitry Baryshkov 2024-11-08  221  
568837beeb38ef Dmitry Baryshkov 2024-11-08  222  	drm_dbg_dp(audio->drm_dev,
568837beeb38ef Dmitry Baryshkov 2024-11-08  223  		   "mainlink_level = 0x%x, safe_to_exit_level = 0x%x\n",
568837beeb38ef Dmitry Baryshkov 2024-11-08  224  		   mainlink_levels, safe_to_exit_level);
568837beeb38ef Dmitry Baryshkov 2024-11-08  225  
568837beeb38ef Dmitry Baryshkov 2024-11-08  226  	msm_dp_write_link(audio->catalog, REG_DP_MAINLINK_LEVELS, mainlink_levels);
d13e36d7d2227e Abhinav Kumar    2020-09-12  227  }
d13e36d7d2227e Abhinav Kumar    2020-09-12  228  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki