[PATCH] drm: rework FB_CORE dependency

Arnd Bergmann arnd at arndb.de
Fri Nov 15 16:35:46 UTC 2024


On Fri, Nov 15, 2024, at 16:54, Thomas Zimmermann wrote:
> Am 15.11.24 um 16:27 schrieb Arnd Bergmann:
>>   
>> @@ -220,7 +221,6 @@ config DRM_CLIENT_LIB
>>   	tristate
>>   	depends on DRM
>>   	select DRM_KMS_HELPER if DRM_FBDEV_EMULATION
>> -	select FB_CORE if DRM_FBDEV_EMULATION
>
> This should remain. More fbdev code will move into drm_fbdev_client.c 
> and that will require FB_CORE.

Got it.

>>   	help
>>   	  This option enables the DRM client library and selects all
>>   	  modules and components according to the enabled clients.
>> @@ -372,6 +372,7 @@ config DRM_GEM_SHMEM_HELPER
>>   	tristate
>>   	depends on DRM && MMU
>>   	select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
>> +	select FB_CORE if DRM_FBDEV_EMULATION
>
> This select is also needed by DRM_GEM_DMA_HELPER and DRM_GEM_TTM_HELPER.
>
> Please sort these select statements alphabetically.

Sent a v2 now.

     Arnd


More information about the dri-devel mailing list