[PATCH v6 2/7] drm/sched: store the drm client_id in drm_sched_fence
kernel test robot
lkp at intel.com
Sun Nov 17 02:10:58 UTC 2024
Hi Pierre-Eric,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-xe/drm-xe-next]
[also build test ERROR on next-20241115]
[cannot apply to linus/master drm-misc/drm-misc-next v6.12-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pierre-Eric-Pelloux-Prayer/drm-debugfs-output-client_id-in-in-drm_clients_info/20241114-180547
base: https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link: https://lore.kernel.org/r/20241114100113.150647-3-pierre-eric.pelloux-prayer%40amd.com
patch subject: [PATCH v6 2/7] drm/sched: store the drm client_id in drm_sched_fence
config: arm-randconfig-002-20241117 (https://download.01.org/0day-ci/archive/20241117/202411170920.6ntlbMfi-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411170920.6ntlbMfi-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411170920.6ntlbMfi-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/panthor/panthor_mmu.c:5:
In file included from include/drm/drm_debugfs.h:38:
In file included from include/drm/drm_gpuvm.h:34:
In file included from include/drm/drm_gem.h:42:
In file included from include/drm/drm_vma_manager.h:27:
In file included from include/linux/mm.h:2213:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/gpu/drm/panthor/panthor_mmu.c:2472:57: error: too few arguments to function call, expected 5, have 4
2472 | ret = drm_sched_job_init(&job->base, &vm->entity, 1, vm);
| ~~~~~~~~~~~~~~~~~~ ^
include/drm/gpu_scheduler.h:571:5: note: 'drm_sched_job_init' declared here
571 | int drm_sched_job_init(struct drm_sched_job *job,
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
572 | struct drm_sched_entity *entity,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
573 | u32 credits, void *owner,
| ~~~~~~~~~~~~~~~~~~~~~~~~~
574 | uint64_t drm_client_id);
| ~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
--
In file included from drivers/gpu/drm/panthor/panthor_sched.c:6:
In file included from include/drm/drm_gem_shmem_helper.h:7:
In file included from include/linux/mm.h:2213:
include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
>> drivers/gpu/drm/panthor/panthor_sched.c:3729:25: error: too few arguments to function call, expected 5, have 4
3727 | ret = drm_sched_job_init(&job->base,
| ~~~~~~~~~~~~~~~~~~
3728 | &job->group->queues[job->queue_idx]->entity,
3729 | credits, job->group);
| ^
include/drm/gpu_scheduler.h:571:5: note: 'drm_sched_job_init' declared here
571 | int drm_sched_job_init(struct drm_sched_job *job,
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
572 | struct drm_sched_entity *entity,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
573 | u32 credits, void *owner,
| ~~~~~~~~~~~~~~~~~~~~~~~~~
574 | uint64_t drm_client_id);
| ~~~~~~~~~~~~~~~~~~~~~~
1 warning and 1 error generated.
vim +2472 drivers/gpu/drm/panthor/panthor_mmu.c
647810ec247641e Boris Brezillon 2024-02-29 2435
647810ec247641e Boris Brezillon 2024-02-29 2436 /**
647810ec247641e Boris Brezillon 2024-02-29 2437 * panthor_vm_bind_job_create() - Create a VM_BIND job
647810ec247641e Boris Brezillon 2024-02-29 2438 * @file: File.
647810ec247641e Boris Brezillon 2024-02-29 2439 * @vm: VM targeted by the VM_BIND job.
647810ec247641e Boris Brezillon 2024-02-29 2440 * @op: VM operation data.
647810ec247641e Boris Brezillon 2024-02-29 2441 *
647810ec247641e Boris Brezillon 2024-02-29 2442 * Return: A valid pointer on success, an ERR_PTR() otherwise.
647810ec247641e Boris Brezillon 2024-02-29 2443 */
647810ec247641e Boris Brezillon 2024-02-29 2444 struct drm_sched_job *
647810ec247641e Boris Brezillon 2024-02-29 2445 panthor_vm_bind_job_create(struct drm_file *file,
647810ec247641e Boris Brezillon 2024-02-29 2446 struct panthor_vm *vm,
647810ec247641e Boris Brezillon 2024-02-29 2447 const struct drm_panthor_vm_bind_op *op)
647810ec247641e Boris Brezillon 2024-02-29 2448 {
647810ec247641e Boris Brezillon 2024-02-29 2449 struct panthor_vm_bind_job *job;
647810ec247641e Boris Brezillon 2024-02-29 2450 int ret;
647810ec247641e Boris Brezillon 2024-02-29 2451
647810ec247641e Boris Brezillon 2024-02-29 2452 if (!vm)
647810ec247641e Boris Brezillon 2024-02-29 2453 return ERR_PTR(-EINVAL);
647810ec247641e Boris Brezillon 2024-02-29 2454
647810ec247641e Boris Brezillon 2024-02-29 2455 if (vm->destroyed || vm->unusable)
647810ec247641e Boris Brezillon 2024-02-29 2456 return ERR_PTR(-EINVAL);
647810ec247641e Boris Brezillon 2024-02-29 2457
647810ec247641e Boris Brezillon 2024-02-29 2458 job = kzalloc(sizeof(*job), GFP_KERNEL);
647810ec247641e Boris Brezillon 2024-02-29 2459 if (!job)
647810ec247641e Boris Brezillon 2024-02-29 2460 return ERR_PTR(-ENOMEM);
647810ec247641e Boris Brezillon 2024-02-29 2461
647810ec247641e Boris Brezillon 2024-02-29 2462 ret = panthor_vm_bind_prepare_op_ctx(file, vm, op, &job->ctx);
647810ec247641e Boris Brezillon 2024-02-29 2463 if (ret) {
647810ec247641e Boris Brezillon 2024-02-29 2464 kfree(job);
647810ec247641e Boris Brezillon 2024-02-29 2465 return ERR_PTR(ret);
647810ec247641e Boris Brezillon 2024-02-29 2466 }
647810ec247641e Boris Brezillon 2024-02-29 2467
647810ec247641e Boris Brezillon 2024-02-29 2468 INIT_WORK(&job->cleanup_op_ctx_work, panthor_vm_bind_job_cleanup_op_ctx_work);
647810ec247641e Boris Brezillon 2024-02-29 2469 kref_init(&job->refcount);
647810ec247641e Boris Brezillon 2024-02-29 2470 job->vm = panthor_vm_get(vm);
647810ec247641e Boris Brezillon 2024-02-29 2471
647810ec247641e Boris Brezillon 2024-02-29 @2472 ret = drm_sched_job_init(&job->base, &vm->entity, 1, vm);
647810ec247641e Boris Brezillon 2024-02-29 2473 if (ret)
647810ec247641e Boris Brezillon 2024-02-29 2474 goto err_put_job;
647810ec247641e Boris Brezillon 2024-02-29 2475
647810ec247641e Boris Brezillon 2024-02-29 2476 return &job->base;
647810ec247641e Boris Brezillon 2024-02-29 2477
647810ec247641e Boris Brezillon 2024-02-29 2478 err_put_job:
647810ec247641e Boris Brezillon 2024-02-29 2479 panthor_vm_bind_job_put(&job->base);
647810ec247641e Boris Brezillon 2024-02-29 2480 return ERR_PTR(ret);
647810ec247641e Boris Brezillon 2024-02-29 2481 }
647810ec247641e Boris Brezillon 2024-02-29 2482
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the dri-devel
mailing list