[PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

[Krzysztof Kozlowski]

On 21/11/2024 03:15, Keith Zhao wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk at kernel.org>
>> Sent: 2024年11月20日 15:38
>> To: Keith Zhao <keith.zhao at starfivetech.com>; devicetree at vger.kernel.org;
>> dri-devel at lists.freedesktop.org
>> Cc: andrzej.hajda at intel.com; neil.armstrong at linaro.org; rfoss at kernel.org;
>> Laurent.pinchart at ideasonboard.com; jonas at kwiboo.se;
>> jernej.skrabec at gmail.com; maarten.lankhorst at linux.intel.com;
>> mripard at kernel.org; tzimmermann at suse.de; airlied at gmail.com;
>> simona at ffwll.ch; robh at kernel.org; krzk+dt at kernel.org; conor+dt at kernel.org;
>> hjc at rock-chips.com; heiko at sntech.de; andy.yan at rock-chips.com; William Qiu
>> <william.qiu at starfivetech.com>; Xingyu Wu <xingyu.wu at starfivetech.com>;
>> kernel at esmil.dk; paul.walmsley at sifive.com; palmer at dabbelt.com;
>> aou at eecs.berkeley.edu; p.zabel at pengutronix.de; Changhuang Liang
>> <changhuang.liang at starfivetech.com>; Jack Zhu <jack.zhu at starfivetech.com>;
>> linux-kernel at vger.kernel.org
>> Subject: Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.
>>
>> On 20/11/2024 07:18, keith zhao wrote:
>>> +	/* Unmute hotplug interrupt */
>>> +	hdmi_modb(hdmi, HDMI_STATUS, m_MASK_INT_HOTPLUG,
>>> +v_MASK_INT_HOTPLUG(1));
>>> +
>>> +	ret = devm_request_threaded_irq(hdmi->dev, irq, inno_hdmi_hardirq,
>>> +					inno_hdmi_irq, IRQF_SHARED,
>>> +					dev_name(hdmi->dev), hdmi);
>>> +	return ret;
>>> +}
>>> +EXPORT_SYMBOL_GPL(inno_hdmi_bind);
>>> +
>>> +MODULE_AUTHOR("Keith Zhao <keithzhao at starfivetech.com>");
>>> +MODULE_DESCRIPTION("INNO HDMI transmitter driver");
>>> +MODULE_LICENSE("GPL"); MODULE_ALIAS("platform:inno-hdmi");
>>
>> You should not need MODULE_ALIAS() in normal cases. If you need it, usually it
>> means your device ID table is wrong (e.g. misses either entries or
>> MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute for incomplete
>> ID table.
>>
> Thank you for your suggestion! 
> I will review the device ID table to ensure its completeness 
> and avoid using MODULE_ALIAS().

In this context neither MODULE_ALIAS nor ID table are suitable/needed.
If you need them, means your driver does not build in all setups :/
Best regards,
Krzysztof