[PATCH 0/8] Display Global Histogram
Daniel Stone
daniel at fooishbar.org
Thu Nov 21 13:40:16 UTC 2024
Hi Arun,
On Thu, 21 Nov 2024 at 12:35, Arun R Murthy <arun.r.murthy at intel.com> wrote:
> The corresponding mutter changes to enable/disable histogram, read the
> histogram data, communicate with the library and write the enhanced data
> back to the KMD is also pushed for review at https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3873
Again, the Mutter MR which is linked does _not_ write anything back to
the KMS driver. It would be much more clear to explain in your cover
letters that it currently reads the histogram values and does nothing
with them, and that an expected next step is to make it write the
processed values back to the KMS driver. Even though I'm sure your
intention is not to mislead anyone, what you are writing here is not
actually true.
Cheers,
Daniel
More information about the dri-devel
mailing list