[PATCH 1/2] drm/cirrus: Use virtual encoder and connector types

Gerd Hoffmann kraxel at redhat.com
Mon Nov 25 11:22:47 UTC 2024


On Sat, Nov 23, 2024 at 06:28:30PM +0200, Dmitry Baryshkov wrote:
> On Tue, Oct 29, 2024 at 03:34:23PM +0100, Thomas Zimmermann wrote:
> > The cirrus driver only works on emulated Cirrus hardware. Use the
> > correct types for encoder and connector.

> >  	connector = &cirrus->connector;
> >  	ret = drm_connector_init(dev, connector, &cirrus_connector_funcs,
> > -				 DRM_MODE_CONNECTOR_VGA);
> > +				 DRM_MODE_CONNECTOR_VIRTUAL);
> 
> This will also remove the EDID property from this connector. I'm not
> sore if that is an expected behaviour or not.

Well, the qemu cirrus emulation does not actually provide an EDID,
so this is probably a good thing (even if possibly not intentional).

take care,
  Gerd



More information about the dri-devel mailing list