[PATCH v3 2/4] arm64: dts: qcom: x1e80100-vivobook-s15: Use the samsung,atna33xc20 panel driver

[Maud Spierings]

On 11/25/24 1:21 PM, Konrad Dybcio wrote:
> On 24.11.2024 11:00 AM, Maud Spierings via B4 Relay wrote:
>> From: Maud Spierings <maud_spierings at hotmail.com>
>>
>> The Asus vivobook s15 uses the ATNA56AC03 panel.
>> This panel is controlled by the atna33xc20 driver instead of the generic
>> edp-panel driver
>>
>> Signed-off-by: Maud Spierings <maud_spierings at hotmail.com>
>> ---
>>   arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 16 +++++++++++++++-
>>   1 file changed, 15 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
>> index f25991b887de3fca0092c5f81c881c5d8bd71aac..dbc85aff50a95bfc2ac11528d1901979ec7b1501 100644
>> --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
>> +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts
>> @@ -407,9 +407,13 @@ &mdss_dp3 {
>>   
>>   	aux-bus {
>>   		panel {
>> -			compatible = "edp-panel";
>> +			compatible = "samsung,atna56ac03", "samsung,atna33xc20";
>> +			enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
>>   			power-supply = <&vreg_edp_3p3>;
>>   
>> +			pinctrl-0 = <&edp_bl_en>;
>> +			pinctrl-names = "default";
>> +
>>   			port {
>>   				edp_panel_in: endpoint {
>>   					remote-endpoint = <&mdss_dp3_out>;
>> @@ -475,6 +479,16 @@ &pcie6a_phy {
>>   	status = "okay";
>>   };
>>   
>> +&pmc8380_3_gpios {
>> +	edp_bl_en: edp-bl-en-state {
>> +		pins = "gpio4";
>> +		function = "normal";
>> +		power-source = <0>;
> This is <1> on other boards.. I'm guessing you verified this against
> at-boot values?
>
> Konrad
I checked all the other gpios in these patches but it seems I did not do 
the same for this one. It is indeed supposed to be <1>, I wonder if the 
lenovo slim 7 dts is wrong too then.

Anyways, I will fix this, with a couple of other parameters that have to 
be added as well.

Terribly sorry for the lack of checking and thank you for spotting this.

Kind regards, Maud