[PATCH v2 1/5] dt-bindings: display: Add Apple pre-DCP display controller bindings

Krzysztof Kozlowski krzk at kernel.org
Tue Nov 26 16:54:02 UTC 2024


On 26/11/2024 17:46, Krzysztof Kozlowski wrote:
> 
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  max-brightness: true
>> +
>> +  port: true
> 
> No, these cannot be true without definition. Again, please open existing
> bindings and use them as example. You probably miss here some reference,
> but max-brightness for panel is a bit confusing. I asked already and did
> not get answer: isn't this backlight property? What is this device -
> backlight or panel? If panel, then what bus?
You responded to my comment in exactly the same moment you sent this
patchset which gives me around 0 seconds to reply to your comment.

Give reviewers some time if you disagree with them, otherwise I find
wrong sending next version immediately.

Best regards,
Krzysztof


More information about the dri-devel mailing list