[PATCH] drm/panthor: Add FOP_UNSIGNED_OFFSET to fop_flags
Heiko Stübner
heiko at sntech.de
Tue Oct 1 12:44:38 UTC 2024
Am Freitag, 20. September 2024, 12:28:02 CEST schrieb Liviu Dudau:
> Since 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> the FMODE_UNSIGNED_OFFSET flag has been moved to fop_flags and renamed,
> but the patch failed to make the changes for the panthor driver.
> When user space opens the render node the WARN() added by the patch
> gets triggered.
>
> Fixes: 641bb4394f40 ("fs: move FMODE_UNSIGNED_OFFSET to fop_flags")
> Cc: Christian Brauner <brauner at kernel.org>
> Signed-off-by: Liviu Dudau <liviu.dudau at arm.com>
On a rk3588-tiger-haikou
Tested-by: Heiko Stuebner <heiko at sntech.de>
with 6.11 panthor was working nicely
with 6.12-rc1 panthor was not recognized by mesa anymore
with this patch applied on top, things are back to a working state.
> ---
> drivers/gpu/drm/panthor/panthor_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/panthor/panthor_drv.c
> index 34182f67136c1..c520f156e2d73 100644
> --- a/drivers/gpu/drm/panthor/panthor_drv.c
> +++ b/drivers/gpu/drm/panthor/panthor_drv.c
> @@ -1383,6 +1383,7 @@ static const struct file_operations panthor_drm_driver_fops = {
> .read = drm_read,
> .llseek = noop_llseek,
> .mmap = panthor_mmap,
> + .fop_flags = FOP_UNSIGNED_OFFSET,
> };
>
> #ifdef CONFIG_DEBUG_FS
>
More information about the dri-devel
mailing list