[PATCH v4 0/2] Use user-defined workqueue lockdep map for drm sched
Matthew Brost
matthew.brost at intel.com
Wed Oct 2 13:16:37 UTC 2024
By default, each DRM scheduler instance creates an ordered workqueue for
submission, and each workqueue creation allocates a new lockdep map.
This becomes problematic when a DRM scheduler is created for every user
queue (e.g., in DRM drivers with firmware schedulers like Xe) due to the
limited number of available lockdep maps. With numerous user queues
being created and destroyed, lockdep may run out of maps, leading to
lockdep being disabled. Xe mitigated this by creating a pool of
workqueues for DRM scheduler use. However, this approach also encounters
issues if the driver is unloaded and reloaded multiple times or if many
VFs are probed.
To address this, we propose creating a single lockdep map for all DRM
scheduler workqueues, which will also resolve issues for other DRM
drivers that create a DRM scheduler per user queue.
This solution has been tested by unloading and reloading the Xe driver.
Before this series, around 30 driver reloads would result in lockdep
being turned off. After implementing the series, the driver can be
unloaded and reloaded hundreds of times without issues.
v2:
- Split workqueue changes into multiple patches
- Add alloc_workqueue_lockdep_map (Tejun)
- Drop RFC
v3:
- Drop __WQ_USER_OWNED_LOCKDEP (Tejun)
- static inline alloc_ordered_workqueue_lockdep_map (Tejun)
v4:
- Rebase on 6.12 which has required work queue patches
Matt
Matthew Brost (2):
drm/sched: Use drm sched lockdep map for submit_wq
drm/xe: Drop GuC submit_wq pool
drivers/gpu/drm/scheduler/sched_main.c | 11 +++++
drivers/gpu/drm/xe/xe_guc_submit.c | 60 +-------------------------
drivers/gpu/drm/xe/xe_guc_types.h | 7 ---
3 files changed, 12 insertions(+), 66 deletions(-)
--
2.34.1
More information about the dri-devel
mailing list