[PATCH 2/2] dt-bindings: display: bridge: sil,sii9022: Add data-lines
Krzysztof Kozlowski
krzk at kernel.org
Thu Oct 3 10:03:52 UTC 2024
On 03/10/2024 10:20, Wadim Egorov wrote:
> The SI9022 HDMI transmitter can be configured with 16, 18, or 24 input
> data lines. This commit introduces the data-lines property to the input
lines? lanes? What are lines? like pins?
> endpoint, specifying the number of parallel RGB input pins connected
> to the transmitter.
>
> Signed-off-by: Wadim Egorov <w.egorov at phytec.de>
> ---
> .../bindings/display/bridge/sil,sii9022.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml b/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml
> index 5a69547ad3d7..24306f8eb107 100644
> --- a/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/sil,sii9022.yaml
> @@ -81,9 +81,20 @@ properties:
>
> properties:
> port at 0:
> - $ref: /schemas/graph.yaml#/properties/port
> + unevaluatedProperties: false
> + $ref: /schemas/graph.yaml#/$defs/port-base
> description: Parallel RGB input port
>
> + properties:
> + endpoint:
> + $ref: /schemas/graph.yaml#/$defs/endpoint-base
> + unevaluatedProperties: false
> +
> + properties:
> + data-lines:
No, this will confuse everyone. Considering lack of description how
anyone would figure out what this means?
I don't know much about RGB parallel port to advice how this should be
called. Can you describe the hardware more?
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [ 16, 18, 24 ]
> +
> port at 1:
> $ref: /schemas/graph.yaml#/properties/port
> description: HDMI output port
Best regards,
Krzysztof
More information about the dri-devel
mailing list