[PATCH] drm/bochs: Return error from correct pointer

Javier Martinez Canillas javierm at redhat.com
Fri Oct 4 08:13:27 UTC 2024


Thomas Zimmermann <tzimmermann at suse.de> writes:

Hello Thomas,

> In probe, return the error code from the variable bochs, not dev. The
> variable dev has not been initialized at this point. In the case of an
> allocation error, the returned value would have been undefined.
>
> Reported-by: Kees Bakker <kees at ijzerbout.nl>
> Closes: https://lore.kernel.org/dri-devel/8c5bfc12-cbcc-4102-9826-494060df4179@ijzerbout.nl/
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> Fixes: 04826f588682 ("drm/bochs: Allocate DRM device in struct bochs_device")
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: Gerd Hoffmann <kraxel at redhat.com>
> Cc: virtualization at lists.linux.dev
> ---

Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



More information about the dri-devel mailing list