[PATCH] fbdev: Switch back to struct platform_driver::remove()

Helge Deller deller at gmx.de
Mon Oct 7 19:44:50 UTC 2024


Hi Uwe,

On 10/7/24 18:35, Uwe Kleine-König wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
>
> Convert all platform drivers below drivers/dma after the previous
> conversion commits apart from the wireless drivers to use .remove(),
> with the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is done
> by just changing the structure member name in the driver initializer.
>
> While touching these files, make indention of the struct initializer
> consistent in several files.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at baylibre.com>
> ---
> Hello,
>
> given the simplicity of the individual changes I do this all in a single
> patch. I you don't agree, please tell and I will happily split it.

I'm not a fan of everything in one patch since it makes backporting
other patches complicated. But in this case I think we should keep it
simple by using one patch.

> It's based on Friday's next, feel free to drop changes that result in a
> conflict when you come around to apply this. I'll care for the fallout
> at a later time then. (Having said that, if you use b4 am -3 and git am
> -3, there should be hardly any conflict.)

Patch applied cleanly.

> Note I didn't Cc: all the individual driver maintainers to not trigger
> sending limits and spam filters.

I think that's ok.

I've added your patch as-is to the fbdev for-next git tree to
check for possible errors.
Let's monitor it a few days, then I suppose we should push it upstream.

Thanks!
Helge

>
> Best regards
> Uwe
>
>   drivers/video/fbdev/amifb.c                               | 4 ++--
>   drivers/video/fbdev/arcfb.c                               | 2 +-
>   drivers/video/fbdev/atmel_lcdfb.c                         | 2 +-
>   drivers/video/fbdev/au1100fb.c                            | 2 +-
>   drivers/video/fbdev/au1200fb.c                            | 2 +-
>   drivers/video/fbdev/broadsheetfb.c                        | 2 +-
>   drivers/video/fbdev/bw2.c                                 | 2 +-
>   drivers/video/fbdev/cg14.c                                | 2 +-
>   drivers/video/fbdev/cg3.c                                 | 2 +-
>   drivers/video/fbdev/cg6.c                                 | 2 +-
>   drivers/video/fbdev/clps711x-fb.c                         | 2 +-
>   drivers/video/fbdev/cobalt_lcdfb.c                        | 2 +-
>   drivers/video/fbdev/da8xx-fb.c                            | 2 +-
>   drivers/video/fbdev/ep93xx-fb.c                           | 2 +-
>   drivers/video/fbdev/ffb.c                                 | 2 +-
>   drivers/video/fbdev/fsl-diu-fb.c                          | 6 +++---
>   drivers/video/fbdev/gbefb.c                               | 6 +++---
>   drivers/video/fbdev/goldfishfb.c                          | 2 +-
>   drivers/video/fbdev/grvga.c                               | 2 +-
>   drivers/video/fbdev/hecubafb.c                            | 2 +-
>   drivers/video/fbdev/hgafb.c                               | 2 +-
>   drivers/video/fbdev/hitfb.c                               | 2 +-
>   drivers/video/fbdev/imxfb.c                               | 2 +-
>   drivers/video/fbdev/leo.c                                 | 2 +-
>   drivers/video/fbdev/mb862xx/mb862xxfbdrv.c                | 2 +-
>   drivers/video/fbdev/metronomefb.c                         | 2 +-
>   drivers/video/fbdev/ocfb.c                                | 2 +-
>   drivers/video/fbdev/offb.c                                | 4 ++--
>   drivers/video/fbdev/omap/omapfb_main.c                    | 2 +-
>   .../fbdev/omap2/omapfb/displays/connector-analog-tv.c     | 2 +-
>   drivers/video/fbdev/omap2/omapfb/displays/connector-dvi.c | 2 +-
>   .../video/fbdev/omap2/omapfb/displays/connector-hdmi.c    | 2 +-
>   .../video/fbdev/omap2/omapfb/displays/encoder-opa362.c    | 2 +-
>   .../video/fbdev/omap2/omapfb/displays/encoder-tfp410.c    | 2 +-
>   .../video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c | 2 +-
>   drivers/video/fbdev/omap2/omapfb/displays/panel-dpi.c     | 2 +-
>   drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c  | 2 +-
>   .../fbdev/omap2/omapfb/displays/panel-sharp-ls037v7dw01.c | 2 +-
>   drivers/video/fbdev/omap2/omapfb/dss/core.c               | 6 +++---
>   drivers/video/fbdev/omap2/omapfb/dss/dispc.c              | 2 +-
>   drivers/video/fbdev/omap2/omapfb/dss/dpi.c                | 4 ++--
>   drivers/video/fbdev/omap2/omapfb/dss/dsi.c                | 2 +-
>   drivers/video/fbdev/omap2/omapfb/dss/dss.c                | 2 +-
>   drivers/video/fbdev/omap2/omapfb/dss/hdmi4.c              | 6 +++---
>   drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c              | 2 +-
>   drivers/video/fbdev/omap2/omapfb/dss/sdi.c                | 6 +++---
>   drivers/video/fbdev/omap2/omapfb/dss/venc.c               | 6 +++---
>   drivers/video/fbdev/omap2/omapfb/omapfb-main.c            | 2 +-
>   drivers/video/fbdev/p9100.c                               | 2 +-
>   drivers/video/fbdev/platinumfb.c                          | 2 +-
>   drivers/video/fbdev/pxa168fb.c                            | 2 +-
>   drivers/video/fbdev/pxa3xx-gcu.c                          | 8 ++++----
>   drivers/video/fbdev/pxafb.c                               | 2 +-
>   drivers/video/fbdev/s1d13xxxfb.c                          | 2 +-
>   drivers/video/fbdev/s3c-fb.c                              | 2 +-
>   drivers/video/fbdev/sh7760fb.c                            | 2 +-
>   drivers/video/fbdev/sh_mobile_lcdcfb.c                    | 2 +-
>   drivers/video/fbdev/simplefb.c                            | 2 +-
>   drivers/video/fbdev/sm501fb.c                             | 2 +-
>   drivers/video/fbdev/tcx.c                                 | 2 +-
>   drivers/video/fbdev/uvesafb.c                             | 2 +-
>   drivers/video/fbdev/vesafb.c                              | 2 +-
>   drivers/video/fbdev/vfb.c                                 | 2 +-
>   drivers/video/fbdev/vga16fb.c                             | 2 +-
>   drivers/video/fbdev/via/via-gpio.c                        | 2 +-
>   drivers/video/fbdev/via/via_i2c.c                         | 2 +-
>   drivers/video/fbdev/vt8500lcdfb.c                         | 2 +-
>   drivers/video/fbdev/wm8505fb.c                            | 2 +-
>   drivers/video/fbdev/wmt_ge_rops.c                         | 2 +-
>   drivers/video/fbdev/xilinxfb.c                            | 2 +-
>   70 files changed, 88 insertions(+), 88 deletions(-)
>
> diff --git a/drivers/video/fbdev/amifb.c b/drivers/video/fbdev/amifb.c
> index 132638240521..1116a0789ca4 100644
> --- a/drivers/video/fbdev/amifb.c
> +++ b/drivers/video/fbdev/amifb.c
> @@ -3774,8 +3774,8 @@ static void __exit amifb_remove(struct platform_device *pdev)
>    * triggers a section mismatch warning.
>    */
>   static struct platform_driver amifb_driver __refdata = {
> -	.remove_new = __exit_p(amifb_remove),
> -	.driver   = {
> +	.remove = __exit_p(amifb_remove),
> +	.driver = {
>   		.name	= "amiga-video",
>   	},
>...



More information about the dri-devel mailing list