[bug report] drm: add DRM_SET_CLIENT_NAME ioctl

Dan Carpenter dan.carpenter at linaro.org
Fri Oct 11 08:22:35 UTC 2024


On Fri, Oct 11, 2024 at 10:20:03AM +0200, Pierre-Eric Pelloux-Prayer wrote:
> 
> Hi,
> 
> Le 10/10/2024 à 12:02, Dan Carpenter a écrit :
> > Hello Pierre-Eric Pelloux-Prayer,
> > 
> > Commit 56c594d8df64 ("drm: add DRM_SET_CLIENT_NAME ioctl") from Oct
> > 3, 2024 (linux-next), leads to the following Smatch static checker
> > warning:
> > 
> > 	drivers/gpu/drm/drm_debugfs.c:104 drm_clients_info()
> > 	warn: was precision intended? '64'
> > 
> > drivers/gpu/drm/drm_debugfs.c
> >      73 static int drm_clients_info(struct seq_file *m, void *data)
> >      74 {
> >      75         struct drm_debugfs_entry *entry = m->private;
> >      76         struct drm_device *dev = entry->dev;
> >      77         struct drm_file *priv;
> >      78         kuid_t uid;
> >      79
> >      80         seq_printf(m,
> >      81                    "%20s %5s %3s master a %5s %10s %*s\n",
> >                                                            ^^^
> > this was probably intended to be %.*s
> 
> No. The intent is to right-align the string, similar to what is done for the other
> string fields.
> It could have been written %64s, but since DRM_CLIENT_NAME_MAX_LEN exist, I've used
> the %*s syntax.
> 

Ah, fine.  Sorry for the noise.

regards,
dan carpenter



More information about the dri-devel mailing list