[PATCH v12 09/15] drm/vkms: Remove useless drm_rotation_simplify
Louis Chauvet
louis.chauvet at bootlin.com
Fri Oct 11 09:36:35 UTC 2024
Hi all,
Until this point, this series has not received any major comments since
v9. I will commit patches 1-9 next week if there are no further comments.
For patches 10-15, I am currently waiting for feedback from Maxime to
send the next iteration with a fix for kunit tests.
Thanks,
Louis Chauvet
On 07/10/24 - 18:10, Louis Chauvet wrote:
> As all the rotation are now supported by VKMS, this simplification does
> not make sense anymore, so remove it.
>
> Signed-off-by: Louis Chauvet <louis.chauvet at bootlin.com>
> ---
> drivers/gpu/drm/vkms/vkms_plane.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c
> index 8875bed76410..5a028ee96c91 100644
> --- a/drivers/gpu/drm/vkms/vkms_plane.c
> +++ b/drivers/gpu/drm/vkms/vkms_plane.c
> @@ -115,12 +115,7 @@ static void vkms_plane_atomic_update(struct drm_plane *plane,
> frame_info->fb = fb;
> memcpy(&frame_info->map, &shadow_plane_state->data, sizeof(frame_info->map));
> drm_framebuffer_get(frame_info->fb);
> - frame_info->rotation = drm_rotation_simplify(new_state->rotation, DRM_MODE_ROTATE_0 |
> - DRM_MODE_ROTATE_90 |
> - DRM_MODE_ROTATE_270 |
> - DRM_MODE_REFLECT_X |
> - DRM_MODE_REFLECT_Y);
> -
> + frame_info->rotation = new_state->rotation;
>
> vkms_plane_state->pixel_read_line = get_pixel_read_line_function(fmt);
> }
>
> --
> 2.46.2
>
More information about the dri-devel
mailing list