[PATCH 2/5] drm/sched: Stop setting current entity in FIFO mode

[Philipp Stanner]

On Mon, 2024-10-14 at 11:46 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
> 
> It does not seem there is a need to set the current entity in FIFO
> mode
> since ot only serves as being a "cursor" in round-robin mode. Even if

s/ot/it


> scheduling mode is changed at runtime the change in behaviour is
> simply
> to restart from the first entity, instead of continuing in RR mode
> from
> where FIFO left it, and that sounds completely fine.

Imperative sentence: "Remove setting the cursor from
drm_sched_rq_select_entity_fifo()"

Thx
P.

> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: Luben Tuikov <ltuikov89 at gmail.com>
> Cc: Matthew Brost <matthew.brost at intel.com>
> Cc: Philipp Stanner <pstanner at redhat.com>
> Acked-by: Christian König <christian.koenig at amd.com>
> Reviewed-by: Philipp Stanner <pstanner at redhat.com>
> ---
>  drivers/gpu/drm/scheduler/sched_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c
> b/drivers/gpu/drm/scheduler/sched_main.c
> index bbd1630407e4..07ee386b8e4b 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -355,7 +355,6 @@ drm_sched_rq_select_entity_fifo(struct
> drm_gpu_scheduler *sched,
>  				return ERR_PTR(-ENOSPC);
>  			}
>  
> -			rq->current_entity = entity;
>  			reinit_completion(&entity->entity_idle);
>  			break;
>  		}