vc4: HDMI Sink doesn't support RGB, something's wrong.

[Dave Stevenson]

On Mon, 14 Oct 2024 at 22:16, Stefan Wahren <wahrenst at gmx.net> wrote:
>
>
> Am 14.10.24 um 12:54 schrieb Dave Stevenson:
> > On Mon, 14 Oct 2024 at 10:04, Maxime Ripard <mripard at kernel.org> wrote:
> >> Hi,
> >>
> >> On Sun, Oct 13, 2024 at 09:57:58PM GMT, Stefan Wahren wrote:
> >>> Am 13.10.24 um 21:11 schrieb Dave Stevenson:
> >>>> Hi Stefan.
> >>>>
> >>>> On Sun, 13 Oct 2024, 18:19 Stefan Wahren, <wahrenst at gmx.net> wrote:
> >>>>
> >>>>      Hi,
> >>>>
> >>>>      i recently switch for my suspend2idle tests from Raspberry Pi Bullseye
> >>>>      to Bookworm. After that testing suspend2idle shows a new warning
> >>>>      which i
> >>>>      never saw before:
> >>>>
> >>>>      HDMI Sink doesn't support RGB, something's wrong.
> >>>>
> >>>>
> >>>> Can you provide the edid of your display please?
> ...
> >>>
> >>>
> >>> The failure is coming from sink_supports_format_bpc()[1], but the flag
> >>> for DRM_COLOR_FORMAT_RGB444 should have been set from
> >>> update_display_info()[2] parsing the EDID.
> >>>
> >>> Loading that EDID in via drm.edid_firmware has given me a console at
> >>> 1920x1200 at 60 without any issues, so I'm a little confused as to what
> >>> is going on.
> Since this warning only occurs on resume and not during normal boot, i
> would assume there is no issue with EDID. Maybe the flag get lost. I
> should have mention that X11 doesn't recover in this case and the
> display stays black.

Ah, I hadn't realised you meant it was only on resume that it didn't
come back up.

I suspect you're right that the state gets lost somehow. It may be
triggered by the returning of connector_status_unknown on the
connector, but haven't traced it back.

If I pick up your patches, what do I need to add to replicate this?

  Dave