[PATCH v9 3/3] drm/rockchip: Add basic RK3588 HDMI output support

Uwe Kleine-König u.kleine-koenig at baylibre.com
Wed Oct 16 09:27:36 UTC 2024


Hello,

On Thu, Oct 10, 2024 at 01:40:51AM +0300, Cristian Ciocaltea wrote:
> +struct platform_driver dw_hdmi_qp_rockchip_pltfm_driver = {
> +	.probe  = dw_hdmi_qp_rockchip_probe,
> +	.remove_new = dw_hdmi_qp_rockchip_remove,
> +	.driver = {
> +		.name = "dwhdmiqp-rockchip",
> +		.pm = &dw_hdmi_qp_rockchip_pm,
> +		.of_match_table = dw_hdmi_qp_rockchip_dt_ids,
> +	},
> +};

After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
return void") .remove() is (again) the right callback to implement for
platform drivers. Please just drop "_new".

Additionally I suggest to drop one of the white spaces between .probe
and =.

Best regards
Uwe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20241016/762b84d5/attachment-0001.sig>


More information about the dri-devel mailing list