[PATCH 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO NB04 devices

[Pavel Machek]

Hi!

> > > > - interface for setting multiple LEDs at once
> > > > - interface for setting a range of LEDs at once
> > How are LEDs ordered? I don't believe range makes much sense.
> 
> Range would allow for efficiently changing the color of all LEDs. But i agree
> that this can be considered optional and can be added later.

Yep, setting all of them makes sense. We should probably provide
backward-compatible interface for keyboards with single backlight, so
this would likely be LED class.

> > > Personally I really like the idea to just emulate a HID LampArray device
> > > for this instead or rolling our own API.  I believe there need to be
> > > strong arguments to go with some alternative NIH API and I have not
> > > heard such arguments yet.
> > If you don't want "some alternative API", we already have perfectly
> > working API for 2D arrays of LEDs. I believe I mentioned it before
> > :-). Senzrohssre.
> 
> We may have to support 3D arrays of LEDs, so using a simple framebuffer
> would likely cause trouble.

Do you have pointer for device that is 3D?

OpenRGB manages to map keyboard into plane... so what I'd propose is
this:

Framebuffer
Information for each pixel:
	    present ? (displays with missing pixels are pretty common)
	    list of keys related to this pixel
	    width, height, length (if we know them)

Pixels map to keys M:N.

Yes, we'll have some number of non-present pixels, but again, I
believe that's not uncommon due to round screens, etc.

(But I'm fine with other interfaces, as long as they are "normal") 

Best regards,
								Pavel

-- 
People of Russia, stop Putin before his war on Ukraine escalates.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20241022/8cf6a6fb/attachment.sig>