[PATCH v2 2/5] dt-bindings: display: panel: Add Samsung S6E88A0-AMS427AP24 bindings
Krzysztof Kozlowski
krzk at kernel.org
Wed Oct 23 07:16:42 UTC 2024
On Tue, Oct 22, 2024 at 11:33:36PM +0200, Jakob Hauser wrote:
> Add bindings for Samsung AMS427AP24 panel with S6E88A0 controller.
>
> Signed-off-by: Jakob Hauser <jahau at rocketmail.com>
> ---
> Patch is based on current branch drm-misc-next.
>
> Changes in v2:
> - Adapted property "flip-horizontal" to being moved to "panel-common.yaml".
> ---
> .../panel/samsung,s6e88a0-ams427ap24.yaml | 65 +++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams427ap24.yaml
>
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
Use 4 spaces for example indentation.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
Best regards,
Krzysztof
More information about the dri-devel
mailing list