[PATCH next] drm/amdgpu: Fix amdgpu_ip_block_hw_fini()
Mario Limonciello
mario.limonciello at amd.com
Thu Oct 24 15:00:26 UTC 2024
On 10/24/2024 03:17, Dan Carpenter wrote:
> This NULL check is reversed so the function doesn't work.
>
> Fixes: dad01f93f432 ("drm/amdgpu: validate hw_fini before function call")
> Signed-off-by: Dan Carpenter <dan.carpenter at linaro.org>
Thanks!
Reviewed-by: Mario Limonciello <mario.limonciello at amd.com>
Also applied to amd-staging-drm-next.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 91c1f2188498..f12fab13386a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -3309,7 +3309,7 @@ static void amdgpu_ip_block_hw_fini(struct amdgpu_ip_block *ip_block)
> {
> int r;
>
> - if (ip_block->version->funcs->hw_fini) {
> + if (!ip_block->version->funcs->hw_fini) {
> DRM_ERROR("hw_fini of IP block <%s> not defined\n",
> ip_block->version->funcs->name);
> } else {
More information about the dri-devel
mailing list