[PATCH 14/21] drm/msm/dpu: Support quad-pipe in SSPP checking

[Dmitry Baryshkov]

On Tue, 3 Sept 2024 at 10:53, Jun Nie <jun.nie at linaro.org> wrote:
>
> Dmitry Baryshkov <dmitry.baryshkov at linaro.org> 于2024年8月29日周四 19:38写道：
> >
> > > @@ -1033,13 +1030,10 @@ static int dpu_plane_atomic_check(struct drm_plane *plane,
> > >                         return -E2BIG;
> > >                 }
> > >
> > > -               /*
> > > -                * Use multirect for wide plane. We do not support dynamic
> > > -                * assignment of SSPPs, so we know the configuration.
> > > -                */
> > >                 pipe->multirect_index = DPU_SSPP_RECT_0;
> > >                 pipe->multirect_mode = DPU_SSPP_MULTIRECT_PARALLEL;
> > >
> > > +               r_pipe->sspp = pipe->sspp;
> >
> > NAK
> >
> I do not understand what's your point here. If multi-rectangle mode is
> used, the 2 sw_pipe share a
> SSPP structure. Otherwise the right half of mixer pair does not work
> and no display on that side,
> because there is no SSPP to handle in r_pipe setup.

r_pipe->sspp is assigned dynamically and it signifies if r_pipe is to
be used or not. Also if the virtual planes are enabled, r_pipe->sspp
can differ from pipe->sspp.

-- 
With best wishes
Dmitry