[PATCH v5 2/4] drm/panthor: add DRM fdinfo support
kernel test robot
lkp at intel.com
Wed Sep 4 17:45:35 UTC 2024
Hi Adrián,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v6.11-rc6 next-20240904]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Adri-n-Larumbe/drm-panthor-introduce-job-cycle-and-timestamp-accounting/20240904-042645
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20240903202541.430225-3-adrian.larumbe%40collabora.com
patch subject: [PATCH v5 2/4] drm/panthor: add DRM fdinfo support
config: x86_64-buildonly-randconfig-002-20240904 (https://download.01.org/0day-ci/archive/20240905/202409050134.uxrIkhqc-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240905/202409050134.uxrIkhqc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409050134.uxrIkhqc-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/gpu/drm/panthor/panthor_sched.c:322: warning: Excess struct member 'runnable' description in 'panthor_scheduler'
drivers/gpu/drm/panthor/panthor_sched.c:322: warning: Excess struct member 'idle' description in 'panthor_scheduler'
drivers/gpu/drm/panthor/panthor_sched.c:322: warning: Excess struct member 'waiting' description in 'panthor_scheduler'
drivers/gpu/drm/panthor/panthor_sched.c:322: warning: Excess struct member 'has_ref' description in 'panthor_scheduler'
drivers/gpu/drm/panthor/panthor_sched.c:322: warning: Excess struct member 'in_progress' description in 'panthor_scheduler'
drivers/gpu/drm/panthor/panthor_sched.c:322: warning: Excess struct member 'stopped_groups' description in 'panthor_scheduler'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'mem' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'input' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'output' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'input_fw_va' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'output_fw_va' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'gpu_va' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'ref' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'gt' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'sync64' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'bo' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'offset' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'kmap' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'lock' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'id' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'seqno' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'last_fence' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'in_flight_jobs' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'slots' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'slot_count' description in 'panthor_queue'
drivers/gpu/drm/panthor/panthor_sched.c:494: warning: Excess struct member 'profiling_seqno' description in 'panthor_queue'
>> drivers/gpu/drm/panthor/panthor_sched.c:689: warning: Excess struct member 'data' description in 'panthor_group'
>> drivers/gpu/drm/panthor/panthor_sched.c:689: warning: Excess struct member 'lock' description in 'panthor_group'
drivers/gpu/drm/panthor/panthor_sched.c:822: warning: Function parameter or struct member 'profiling_slot' not described in 'panthor_job'
drivers/gpu/drm/panthor/panthor_sched.c:822: warning: Excess struct member 'start' description in 'panthor_job'
drivers/gpu/drm/panthor/panthor_sched.c:822: warning: Excess struct member 'size' description in 'panthor_job'
drivers/gpu/drm/panthor/panthor_sched.c:822: warning: Excess struct member 'latest_flush' description in 'panthor_job'
drivers/gpu/drm/panthor/panthor_sched.c:822: warning: Excess struct member 'start' description in 'panthor_job'
drivers/gpu/drm/panthor/panthor_sched.c:822: warning: Excess struct member 'end' description in 'panthor_job'
drivers/gpu/drm/panthor/panthor_sched.c:822: warning: Excess struct member 'profile_slot' description in 'panthor_job'
drivers/gpu/drm/panthor/panthor_sched.c:1745: warning: Function parameter or struct member 'ptdev' not described in 'panthor_sched_report_fw_events'
drivers/gpu/drm/panthor/panthor_sched.c:1745: warning: Function parameter or struct member 'events' not described in 'panthor_sched_report_fw_events'
drivers/gpu/drm/panthor/panthor_sched.c:2637: warning: Function parameter or struct member 'ptdev' not described in 'panthor_sched_report_mmu_fault'
vim +689 drivers/gpu/drm/panthor/panthor_sched.c
de85488138247d0 Boris Brezillon 2024-02-29 531
de85488138247d0 Boris Brezillon 2024-02-29 532 /**
de85488138247d0 Boris Brezillon 2024-02-29 533 * struct panthor_group - Scheduling group object
de85488138247d0 Boris Brezillon 2024-02-29 534 */
de85488138247d0 Boris Brezillon 2024-02-29 535 struct panthor_group {
de85488138247d0 Boris Brezillon 2024-02-29 536 /** @refcount: Reference count */
de85488138247d0 Boris Brezillon 2024-02-29 537 struct kref refcount;
de85488138247d0 Boris Brezillon 2024-02-29 538
de85488138247d0 Boris Brezillon 2024-02-29 539 /** @ptdev: Device. */
de85488138247d0 Boris Brezillon 2024-02-29 540 struct panthor_device *ptdev;
de85488138247d0 Boris Brezillon 2024-02-29 541
de85488138247d0 Boris Brezillon 2024-02-29 542 /** @vm: VM bound to the group. */
de85488138247d0 Boris Brezillon 2024-02-29 543 struct panthor_vm *vm;
de85488138247d0 Boris Brezillon 2024-02-29 544
de85488138247d0 Boris Brezillon 2024-02-29 545 /** @compute_core_mask: Mask of shader cores that can be used for compute jobs. */
de85488138247d0 Boris Brezillon 2024-02-29 546 u64 compute_core_mask;
de85488138247d0 Boris Brezillon 2024-02-29 547
de85488138247d0 Boris Brezillon 2024-02-29 548 /** @fragment_core_mask: Mask of shader cores that can be used for fragment jobs. */
de85488138247d0 Boris Brezillon 2024-02-29 549 u64 fragment_core_mask;
de85488138247d0 Boris Brezillon 2024-02-29 550
de85488138247d0 Boris Brezillon 2024-02-29 551 /** @tiler_core_mask: Mask of tiler cores that can be used for tiler jobs. */
de85488138247d0 Boris Brezillon 2024-02-29 552 u64 tiler_core_mask;
de85488138247d0 Boris Brezillon 2024-02-29 553
de85488138247d0 Boris Brezillon 2024-02-29 554 /** @max_compute_cores: Maximum number of shader cores used for compute jobs. */
de85488138247d0 Boris Brezillon 2024-02-29 555 u8 max_compute_cores;
de85488138247d0 Boris Brezillon 2024-02-29 556
be7ffc821f5fc2e Liviu Dudau 2024-04-02 557 /** @max_fragment_cores: Maximum number of shader cores used for fragment jobs. */
de85488138247d0 Boris Brezillon 2024-02-29 558 u8 max_fragment_cores;
de85488138247d0 Boris Brezillon 2024-02-29 559
de85488138247d0 Boris Brezillon 2024-02-29 560 /** @max_tiler_cores: Maximum number of tiler cores used for tiler jobs. */
de85488138247d0 Boris Brezillon 2024-02-29 561 u8 max_tiler_cores;
de85488138247d0 Boris Brezillon 2024-02-29 562
de85488138247d0 Boris Brezillon 2024-02-29 563 /** @priority: Group priority (check panthor_csg_priority). */
de85488138247d0 Boris Brezillon 2024-02-29 564 u8 priority;
de85488138247d0 Boris Brezillon 2024-02-29 565
de85488138247d0 Boris Brezillon 2024-02-29 566 /** @blocked_queues: Bitmask reflecting the blocked queues. */
de85488138247d0 Boris Brezillon 2024-02-29 567 u32 blocked_queues;
de85488138247d0 Boris Brezillon 2024-02-29 568
de85488138247d0 Boris Brezillon 2024-02-29 569 /** @idle_queues: Bitmask reflecting the idle queues. */
de85488138247d0 Boris Brezillon 2024-02-29 570 u32 idle_queues;
de85488138247d0 Boris Brezillon 2024-02-29 571
de85488138247d0 Boris Brezillon 2024-02-29 572 /** @fatal_lock: Lock used to protect access to fatal fields. */
de85488138247d0 Boris Brezillon 2024-02-29 573 spinlock_t fatal_lock;
de85488138247d0 Boris Brezillon 2024-02-29 574
de85488138247d0 Boris Brezillon 2024-02-29 575 /** @fatal_queues: Bitmask reflecting the queues that hit a fatal exception. */
de85488138247d0 Boris Brezillon 2024-02-29 576 u32 fatal_queues;
de85488138247d0 Boris Brezillon 2024-02-29 577
de85488138247d0 Boris Brezillon 2024-02-29 578 /** @tiler_oom: Mask of queues that have a tiler OOM event to process. */
de85488138247d0 Boris Brezillon 2024-02-29 579 atomic_t tiler_oom;
de85488138247d0 Boris Brezillon 2024-02-29 580
de85488138247d0 Boris Brezillon 2024-02-29 581 /** @queue_count: Number of queues in this group. */
de85488138247d0 Boris Brezillon 2024-02-29 582 u32 queue_count;
de85488138247d0 Boris Brezillon 2024-02-29 583
de85488138247d0 Boris Brezillon 2024-02-29 584 /** @queues: Queues owned by this group. */
de85488138247d0 Boris Brezillon 2024-02-29 585 struct panthor_queue *queues[MAX_CS_PER_CSG];
de85488138247d0 Boris Brezillon 2024-02-29 586
de85488138247d0 Boris Brezillon 2024-02-29 587 /**
de85488138247d0 Boris Brezillon 2024-02-29 588 * @csg_id: ID of the FW group slot.
de85488138247d0 Boris Brezillon 2024-02-29 589 *
de85488138247d0 Boris Brezillon 2024-02-29 590 * -1 when the group is not scheduled/active.
de85488138247d0 Boris Brezillon 2024-02-29 591 */
de85488138247d0 Boris Brezillon 2024-02-29 592 int csg_id;
de85488138247d0 Boris Brezillon 2024-02-29 593
de85488138247d0 Boris Brezillon 2024-02-29 594 /**
de85488138247d0 Boris Brezillon 2024-02-29 595 * @destroyed: True when the group has been destroyed.
de85488138247d0 Boris Brezillon 2024-02-29 596 *
de85488138247d0 Boris Brezillon 2024-02-29 597 * If a group is destroyed it becomes useless: no further jobs can be submitted
de85488138247d0 Boris Brezillon 2024-02-29 598 * to its queues. We simply wait for all references to be dropped so we can
de85488138247d0 Boris Brezillon 2024-02-29 599 * release the group object.
de85488138247d0 Boris Brezillon 2024-02-29 600 */
de85488138247d0 Boris Brezillon 2024-02-29 601 bool destroyed;
de85488138247d0 Boris Brezillon 2024-02-29 602
de85488138247d0 Boris Brezillon 2024-02-29 603 /**
de85488138247d0 Boris Brezillon 2024-02-29 604 * @timedout: True when a timeout occurred on any of the queues owned by
de85488138247d0 Boris Brezillon 2024-02-29 605 * this group.
de85488138247d0 Boris Brezillon 2024-02-29 606 *
de85488138247d0 Boris Brezillon 2024-02-29 607 * Timeouts can be reported by drm_sched or by the FW. In any case, any
de85488138247d0 Boris Brezillon 2024-02-29 608 * timeout situation is unrecoverable, and the group becomes useless.
de85488138247d0 Boris Brezillon 2024-02-29 609 * We simply wait for all references to be dropped so we can release the
de85488138247d0 Boris Brezillon 2024-02-29 610 * group object.
de85488138247d0 Boris Brezillon 2024-02-29 611 */
de85488138247d0 Boris Brezillon 2024-02-29 612 bool timedout;
de85488138247d0 Boris Brezillon 2024-02-29 613
de85488138247d0 Boris Brezillon 2024-02-29 614 /**
de85488138247d0 Boris Brezillon 2024-02-29 615 * @syncobjs: Pool of per-queue synchronization objects.
de85488138247d0 Boris Brezillon 2024-02-29 616 *
de85488138247d0 Boris Brezillon 2024-02-29 617 * One sync object per queue. The position of the sync object is
de85488138247d0 Boris Brezillon 2024-02-29 618 * determined by the queue index.
de85488138247d0 Boris Brezillon 2024-02-29 619 */
de85488138247d0 Boris Brezillon 2024-02-29 620 struct panthor_kernel_bo *syncobjs;
de85488138247d0 Boris Brezillon 2024-02-29 621
d7baaf2591f58fc Adrián Larumbe 2024-09-03 622 /** @fdinfo: Per-file total cycle and timestamp values reference. */
d7baaf2591f58fc Adrián Larumbe 2024-09-03 623 struct {
d7baaf2591f58fc Adrián Larumbe 2024-09-03 624 /** @data: Pointer to actual per-file sample data. */
d7baaf2591f58fc Adrián Larumbe 2024-09-03 625 struct panthor_gpu_usage *data;
d7baaf2591f58fc Adrián Larumbe 2024-09-03 626
d7baaf2591f58fc Adrián Larumbe 2024-09-03 627 /**
d7baaf2591f58fc Adrián Larumbe 2024-09-03 628 * @lock: Mutex to govern concurrent access from drm file's fdinfo callback
d7baaf2591f58fc Adrián Larumbe 2024-09-03 629 * and job post-completion processing function
d7baaf2591f58fc Adrián Larumbe 2024-09-03 630 */
d7baaf2591f58fc Adrián Larumbe 2024-09-03 631 struct mutex lock;
d7baaf2591f58fc Adrián Larumbe 2024-09-03 632 } fdinfo;
d7baaf2591f58fc Adrián Larumbe 2024-09-03 633
de85488138247d0 Boris Brezillon 2024-02-29 634 /** @state: Group state. */
de85488138247d0 Boris Brezillon 2024-02-29 635 enum panthor_group_state state;
de85488138247d0 Boris Brezillon 2024-02-29 636
de85488138247d0 Boris Brezillon 2024-02-29 637 /**
de85488138247d0 Boris Brezillon 2024-02-29 638 * @suspend_buf: Suspend buffer.
de85488138247d0 Boris Brezillon 2024-02-29 639 *
de85488138247d0 Boris Brezillon 2024-02-29 640 * Stores the state of the group and its queues when a group is suspended.
de85488138247d0 Boris Brezillon 2024-02-29 641 * Used at resume time to restore the group in its previous state.
de85488138247d0 Boris Brezillon 2024-02-29 642 *
de85488138247d0 Boris Brezillon 2024-02-29 643 * The size of the suspend buffer is exposed through the FW interface.
de85488138247d0 Boris Brezillon 2024-02-29 644 */
de85488138247d0 Boris Brezillon 2024-02-29 645 struct panthor_kernel_bo *suspend_buf;
de85488138247d0 Boris Brezillon 2024-02-29 646
de85488138247d0 Boris Brezillon 2024-02-29 647 /**
de85488138247d0 Boris Brezillon 2024-02-29 648 * @protm_suspend_buf: Protection mode suspend buffer.
de85488138247d0 Boris Brezillon 2024-02-29 649 *
de85488138247d0 Boris Brezillon 2024-02-29 650 * Stores the state of the group and its queues when a group that's in
de85488138247d0 Boris Brezillon 2024-02-29 651 * protection mode is suspended.
de85488138247d0 Boris Brezillon 2024-02-29 652 *
de85488138247d0 Boris Brezillon 2024-02-29 653 * Used at resume time to restore the group in its previous state.
de85488138247d0 Boris Brezillon 2024-02-29 654 *
de85488138247d0 Boris Brezillon 2024-02-29 655 * The size of the protection mode suspend buffer is exposed through the
de85488138247d0 Boris Brezillon 2024-02-29 656 * FW interface.
de85488138247d0 Boris Brezillon 2024-02-29 657 */
de85488138247d0 Boris Brezillon 2024-02-29 658 struct panthor_kernel_bo *protm_suspend_buf;
de85488138247d0 Boris Brezillon 2024-02-29 659
de85488138247d0 Boris Brezillon 2024-02-29 660 /** @sync_upd_work: Work used to check/signal job fences. */
de85488138247d0 Boris Brezillon 2024-02-29 661 struct work_struct sync_upd_work;
de85488138247d0 Boris Brezillon 2024-02-29 662
de85488138247d0 Boris Brezillon 2024-02-29 663 /** @tiler_oom_work: Work used to process tiler OOM events happening on this group. */
de85488138247d0 Boris Brezillon 2024-02-29 664 struct work_struct tiler_oom_work;
de85488138247d0 Boris Brezillon 2024-02-29 665
de85488138247d0 Boris Brezillon 2024-02-29 666 /** @term_work: Work used to finish the group termination procedure. */
de85488138247d0 Boris Brezillon 2024-02-29 667 struct work_struct term_work;
de85488138247d0 Boris Brezillon 2024-02-29 668
de85488138247d0 Boris Brezillon 2024-02-29 669 /**
de85488138247d0 Boris Brezillon 2024-02-29 670 * @release_work: Work used to release group resources.
de85488138247d0 Boris Brezillon 2024-02-29 671 *
de85488138247d0 Boris Brezillon 2024-02-29 672 * We need to postpone the group release to avoid a deadlock when
de85488138247d0 Boris Brezillon 2024-02-29 673 * the last ref is released in the tick work.
de85488138247d0 Boris Brezillon 2024-02-29 674 */
de85488138247d0 Boris Brezillon 2024-02-29 675 struct work_struct release_work;
de85488138247d0 Boris Brezillon 2024-02-29 676
de85488138247d0 Boris Brezillon 2024-02-29 677 /**
de85488138247d0 Boris Brezillon 2024-02-29 678 * @run_node: Node used to insert the group in the
de85488138247d0 Boris Brezillon 2024-02-29 679 * panthor_group::groups::{runnable,idle} and
de85488138247d0 Boris Brezillon 2024-02-29 680 * panthor_group::reset.stopped_groups lists.
de85488138247d0 Boris Brezillon 2024-02-29 681 */
de85488138247d0 Boris Brezillon 2024-02-29 682 struct list_head run_node;
de85488138247d0 Boris Brezillon 2024-02-29 683
de85488138247d0 Boris Brezillon 2024-02-29 684 /**
de85488138247d0 Boris Brezillon 2024-02-29 685 * @wait_node: Node used to insert the group in the
de85488138247d0 Boris Brezillon 2024-02-29 686 * panthor_group::groups::waiting list.
de85488138247d0 Boris Brezillon 2024-02-29 687 */
de85488138247d0 Boris Brezillon 2024-02-29 688 struct list_head wait_node;
de85488138247d0 Boris Brezillon 2024-02-29 @689 };
de85488138247d0 Boris Brezillon 2024-02-29 690
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the dri-devel
mailing list