[PATCH -next] drm/i915: Remove extra unlikely helper

Rodrigo Vivi rodrigo.vivi at intel.com
Thu Sep 5 19:44:06 UTC 2024


On Sat, Aug 31, 2024 at 05:46:55PM +0800, Hongbo Li wrote:
> In IS_ERR, the unlikely is used for the input parameter,
> so these is no need to use it again outside.
> 
> Signed-off-by: Hongbo Li <lihongbo22 at huawei.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

and pushing now...

> ---
>  drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> index 01b7587dd1f8..a3b83cfe1726 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -825,7 +825,7 @@ static int eb_select_context(struct i915_execbuffer *eb)
>  	struct i915_gem_context *ctx;
>  
>  	ctx = i915_gem_context_lookup(eb->file->driver_priv, eb->args->rsvd1);
> -	if (unlikely(IS_ERR(ctx)))
> +	if (IS_ERR(ctx))
>  		return PTR_ERR(ctx);
>  
>  	eb->gem_context = ctx;
> -- 
> 2.34.1
> 


More information about the dri-devel mailing list