[PATCH 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools

kernel test robot lkp at intel.com
Fri Sep 6 03:55:02 UTC 2024


Hi Thomas,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20240905]
[cannot apply to drm-xe/drm-xe-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.11-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Thomas-Hellstr-m/drm-ttm-Change-ttm_device_init-to-use-a-struct-instead-of-multiple-bools/20240905-173606
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
patch link:    https://lore.kernel.org/r/20240905093322.29786-2-thomas.hellstrom%40linux.intel.com
patch subject: [PATCH 1/2] drm/ttm: Change ttm_device_init to use a struct instead of multiple bools
config: i386-randconfig-002-20240906 (https://download.01.org/0day-ci/archive/20240906/202409061145.AtKjpWFJ-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240906/202409061145.AtKjpWFJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409061145.AtKjpWFJ-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/drm_gem_vram_helper.c:981:13: error: too many arguments to function call, expected 6, have 7
     978 |         ret = ttm_device_init(&vmm->bdev, &bo_driver, dev->dev,
         |               ~~~~~~~~~~~~~~~
     979 |                                  dev->anon_inode->i_mapping,
     980 |                                  dev->vma_offset_manager,
     981 |                                  false, true);
         |                                         ^~~~
   include/drm/ttm/ttm_device.h:300:5: note: 'ttm_device_init' declared here
     300 | int ttm_device_init(struct ttm_device *bdev, const struct ttm_device_funcs *funcs,
         |     ^               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     301 |                     struct device *dev, struct address_space *mapping,
         |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     302 |                     struct drm_vma_offset_manager *vma_manager,
         |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     303 |                     const struct ttm_device_init_flags flags);
         |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   1 error generated.


vim +981 drivers/gpu/drm/drm_gem_vram_helper.c

6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  969  
c30b225dba01b4 Thomas Zimmermann 2019-09-11  970  static int drm_vram_mm_init(struct drm_vram_mm *vmm, struct drm_device *dev,
b0e40e0805221d Thomas Zimmermann 2019-09-11  971  			    uint64_t vram_base, size_t vram_size)
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  972  {
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  973  	int ret;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  974  
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  975  	vmm->vram_base = vram_base;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  976  	vmm->vram_size = vram_size;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  977  
8af8a109b34fa8 Christian König   2020-10-01  978  	ret = ttm_device_init(&vmm->bdev, &bo_driver, dev->dev,
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  979  				 dev->anon_inode->i_mapping,
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  980  				 dev->vma_offset_manager,
ee5d2a8e549e90 Christian König   2020-10-24 @981  				 false, true);
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  982  	if (ret)
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  983  		return ret;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  984  
37205891d84f92 Dave Airlie       2020-08-04  985  	ret = ttm_range_man_init(&vmm->bdev, TTM_PL_VRAM,
0fe438cec9e1d2 Christian König   2020-09-11  986  				 false, vram_size >> PAGE_SHIFT);
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  987  	if (ret)
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  988  		return ret;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  989  
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  990  	return 0;
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  991  }
6b5ce4a1fb8489 Thomas Zimmermann 2019-09-11  992  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki


More information about the dri-devel mailing list