[PATCH] drm/colorop: get DATA blob ref at duplicate_state

Harry Wentland harry.wentland at amd.com
Tue Sep 10 19:24:19 UTC 2024


Signed-off-by: Harry Wentland <harry.wentland at amd.com>
---

It was a stupid mistake on my part. The duplicate_state
function needs to take a reference to the blob.

This should fix it. Please give it a try if you can.
I'll roll it into the patch that introduces the bug in
my v6.

Harry

 drivers/gpu/drm/drm_colorop.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c
index 86f7f084a73f..fd1cd934df48 100644
--- a/drivers/gpu/drm/drm_colorop.c
+++ b/drivers/gpu/drm/drm_colorop.c
@@ -401,6 +401,9 @@ static void __drm_atomic_helper_colorop_duplicate_state(struct drm_colorop *colo
 {
 	memcpy(state, colorop->state, sizeof(*state));
 
+	if (state->data)
+		drm_property_blob_get(state->data);
+
 	state->bypass = true;
 }
 
-- 
2.46.0



More information about the dri-devel mailing list