[PATCH 8/9] accel/rocket: Add job submission IOCTL

Markus Elfring Markus.Elfring at web.de
Wed Sep 11 12:02:56 UTC 2024


…
> +++ b/drivers/accel/rocket/rocket_job.h
> @@ -0,0 +1,49 @@
…
> +#ifndef __ROCKET_JOB_H__
> +#define __ROCKET_JOB_H__
…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus


More information about the dri-devel mailing list