[PATCH 3/3] drm/amdgpu: use drm_file name
kernel test robot
lkp at intel.com
Thu Sep 12 22:04:00 UTC 2024
Hi Pierre-Eric,
kernel test robot noticed the following build warnings:
[auto build test WARNING on drm-exynos/exynos-drm-next]
[also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-misc/drm-misc-next drm-tip/drm-tip linus/master v6.11-rc7 next-20240912]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Pierre-Eric-Pelloux-Prayer/drm-use-drm_file-name-in-fdinfo/20240911-230058
base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
patch link: https://lore.kernel.org/r/20240911145836.734080-3-pierre-eric.pelloux-prayer%40amd.com
patch subject: [PATCH 3/3] drm/amdgpu: use drm_file name
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240913/202409130526.fve4aEMs-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240913/202409130526.fve4aEMs-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409130526.fve4aEMs-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2374: warning: Function parameter or struct member 'file' not described in 'amdgpu_vm_set_task_info'
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2801: warning: Function parameter or struct member 'ts' not described in 'amdgpu_vm_handle_fault'
vim +2374 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2367
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2368 /**
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2369 * amdgpu_vm_set_task_info - Sets VMs task info.
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2370 *
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2371 * @vm: vm for which to set the info
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2372 */
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2373 void amdgpu_vm_set_task_info(struct amdgpu_vm *vm, struct drm_file *file)
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 @2374 {
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2375 if (!vm->task_info)
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2376 return;
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2377
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2378 if (vm->task_info->pid == current->pid)
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2379 return;
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2380
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2381 vm->task_info->pid = current->pid;
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2382 get_task_comm(vm->task_info->task_name, current);
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2383
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2384 if (current->group_leader->mm != current->mm)
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2385 return;
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2386
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2387 vm->task_info->tgid = current->group_leader->pid;
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2388 __get_task_comm(vm->task_info->process_name, TASK_COMM_LEN,
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2389 current->group_leader);
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2390 /* Append drm_client_name if set. */
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2391 if (file && file->name) {
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2392 int n;
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2393
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2394 mutex_lock(&file->name_lock);
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2395 n = strlen(vm->task_info->process_name);
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2396 if (n < NAME_MAX) {
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2397 if (file->name) {
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2398 vm->task_info->process_name[n] = '/';
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2399 strscpy_pad(&vm->task_info->process_name[n + 1],
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2400 file->name, NAME_MAX - (n + 1));
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2401 }
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2402 }
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2403 mutex_unlock(&file->name_lock);
cd1125e8edc565 Pierre-Eric Pelloux-Prayer 2024-09-11 2404 }
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2405 }
b8f67b9ddf4f8f Shashank Sharma 2024-01-18 2406
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the dri-devel
mailing list